Re: [PATCH 08/10] dt-bindings: media: qcom: Add Qualcomm MIPI C-/D-PHY schema for CSIPHY IPs

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/06/2025 21:31, Konrad Dybcio wrote:
> On 6/13/25 8:28 AM, Krzysztof Kozlowski wrote:
>> On 12/06/2025 19:13, Vladimir Zapolskiy wrote:
>>> On 6/12/25 10:38, Krzysztof Kozlowski wrote:
>>>> On 12/06/2025 03:15, Vladimir Zapolskiy wrote:
>>>>> Add dt-binding schema for Qualcomm CAMSS CSIPHY IP, which provides
>>>>> MIPI C-PHY/D-PHY interfaces on Qualcomm SoCs.
>>>>>
>>>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>>>> ---
>>>
>>> <snip>
>>>
>>>>> +
>>>>> +  clocks:
>>>>> +    maxItems: 2
>>>>> +
>>>>> +  clock-names:
>>>>> +    items:
>>>>> +      - const: csiphy
>>>>> +      - const: csiphy_timer
>>>>
>>>> Drop csiphy from both, redundant. And this points to the first clock
>>>> name not having any useful name. Name equal to device name is not useful.
>>>>
>>>
>>> I got the rationale, but I have no idea how to correct it, since it's
>>> literally the case, the first clock name on the list in 'csiphy'.
>>
>> What do you mean by "list"? You can point me also to internal
>> documentation if that helps.
> 
> So if you do:
> 
> "csiphy_timer" - "csiphy_" you're left with "timer" which makes sense
> 
> however, if you do:
> 
> "csiphy" - "csiphy_", you get "" and Vlad is wondering what to name it

How is the signal named in HPG or diagram? It is possible it has a name
other than "csiphy"...

> 
>>
>>>
>>> What could be an alternative name then?..
>>
>> The real clock input name, signal name. You can also drop the names.
> 
> I don't have the docs before my eyes right now, but I would not be
> surprised if it's also called "csiphy" in there..

Let's check that first.

Best regards,
Krzysztof