From: Sibi Sankar <sibis@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: bjorn.andersson@linaro.org, rjw@rjwysocki.net,
ulf.hansson@linaro.org, agross@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, gregkh@linuxfoundation.org,
pavel@ucw.cz, len.brown@intel.com, rnayak@codeaurora.org,
dianders@chromium.org, khilman@kernel.org
Subject: Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag
Date: Wed, 12 Aug 2020 19:06:26 +0530 [thread overview]
Message-ID: <4f87d7dfbee7553f3ea7a1a6e12b3fa7@codeaurora.org> (raw)
In-Reply-To: <159718192589.1360974.15808376172581486987@swboyd.mtv.corp.google.com>
Hey Stephen,
Thanks for taking time to review the
series!
On 2020-08-12 03:08, Stephen Boyd wrote:
> Quoting Sibi Sankar (2020-08-11 12:02:51)
>> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
>> index ee11502a575b0..3002a2d68936a 100644
>> --- a/include/linux/pm_domain.h
>> +++ b/include/linux/pm_domain.h
>> @@ -55,6 +55,10 @@
>> *
>> * GENPD_FLAG_RPM_ALWAYS_ON: Instructs genpd to always keep the PM
>> domain
>> * powered on except for system suspend.
>> + *
>> + * GENPD_FLAG_SUSPEND_ON: Instructs genpd to keep the PM domain
>> powered
>> + * on during suspend and runtime PM
>> controlled
>
> Maybe, "powered on across system suspend (if it is already powered on)"
> to match the hunk above that talks about system suspend for
> GENPD_FLAG_RPM_ALWAYS_ON. Otherwise someone may think that this powers
> on the genpd during suspend or powers it on during runtime suspend.
Sure, I'll add ^^ in the next re-spin.
>
>> + * otherwise.
>> */
>> #define GENPD_FLAG_PM_CLK (1U << 0)
>> #define GENPD_FLAG_IRQ_SAFE (1U << 1)
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-08-12 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 19:02 [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag Sibi Sankar
2020-08-11 19:02 ` [PATCH 2/2] soc: qcom: aoss: Use " Sibi Sankar
2020-08-11 21:16 ` Doug Anderson
2020-08-11 21:17 ` [PATCH 1/2] PM / Domains: Add " Doug Anderson
2020-08-11 21:38 ` Stephen Boyd
2020-08-12 13:36 ` Sibi Sankar [this message]
2020-08-12 0:19 ` Kevin Hilman
2020-08-12 16:12 ` Sibi Sankar
2020-08-12 9:45 ` Ulf Hansson
2020-08-12 17:02 ` Sibi Sankar
2020-08-13 12:34 ` Ulf Hansson
2020-08-13 17:26 ` Sibi Sankar
2020-08-17 8:44 ` Ulf Hansson
2020-08-17 16:49 ` Sibi Sankar
2020-08-18 8:31 ` Ulf Hansson
2020-08-18 9:03 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f87d7dfbee7553f3ea7a1a6e12b3fa7@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.