All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>,
	Maciek Machnikowski <maciek@machnikowski.net>
Cc: netdev@vger.kernel.org, richardcochran@gmail.com,
	jacob.e.keller@intel.com, darinzon@amazon.com, kuba@kernel.org
Subject: Re: [RFC 0/3] ptp: Add esterror support
Date: Wed, 14 Aug 2024 09:44:29 +0100	[thread overview]
Message-ID: <4fb35444-3508-4f77-9c66-22acf808b93c@linux.dev> (raw)
In-Reply-To: <4c2e99b4-b19e-41f5-a048-3bcc8c33a51c@lunn.ch>

On 13/08/2024 21:05, Andrew Lunn wrote:
> On Tue, Aug 13, 2024 at 12:55:59PM +0000, Maciek Machnikowski wrote:
>> This patch series implements handling of timex esterror field
>> by ptp devices.
>>
>> Esterror field can be used to return or set the estimated error
>> of the clock. This is useful for devices containing a hardware
>> clock that is controlled and synchronized internally (such as
>> a time card) or when the synchronization is pushed to the embedded
>> CPU of a DPU.
> 
> How can you set the estimated error of a clock? Isn't it a properties
> of the hardware, and maybe the network link? A 10BaseT/Half duplex
> link is going to have a bigger error than a 1000BaseT link because the
> bits take longer on the wire etc.

AFAIU, it's in the spec of the hardware, but it can change depending on
the environment, like temperature. The link speed doesn't matter here,
this property can be used to calculate possible drift of the clock in
the micro holdover mode (between sync points).

> What is the device supposed to do with the set value?

It can be used to report the value back to user-space to calculate the
boundaries of "true time" returned by the hardware.

Thanks!

  reply	other threads:[~2024-08-14  8:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 12:55 [RFC 0/3] ptp: Add esterror support Maciek Machnikowski
2024-08-13 12:56 ` [RFC 1/3] ptp: Implement timex " Maciek Machnikowski
2024-08-14  9:29   ` Vadim Fedorenko
2024-08-15  9:33     ` Maciek Machnikowski
2024-08-14 11:46   ` Simon Horman
2024-08-15  9:32     ` Maciek Machnikowski
2024-08-15  4:23   ` Richard Cochran
2024-08-15  9:43     ` Maciek Machnikowski
2024-08-15  9:47     ` Maciek Machnikowski
2024-08-15 21:04       ` Richard Cochran
2024-08-16 16:01   ` kernel test robot
2024-08-17  5:40   ` kernel test robot
2024-08-13 12:56 ` [RFC 2/3] ptp: Implement support for esterror in ptp_mock Maciek Machnikowski
2024-08-13 12:56 ` [RFC 3/3] ptp: Add setting esterror and reading timex structure Maciek Machnikowski
2024-08-13 20:05 ` [RFC 0/3] ptp: Add esterror support Andrew Lunn
2024-08-14  8:44   ` Vadim Fedorenko [this message]
2024-08-14 13:08     ` Andrew Lunn
2024-08-14 15:08       ` Maciek Machnikowski
2024-08-15  3:53         ` Richard Cochran
2024-08-15  9:40           ` Maciek Machnikowski
2024-08-15 14:26             ` Andrew Lunn
2024-08-15 15:00               ` Maciek Machnikowski
2024-08-15 21:08                 ` Richard Cochran
2024-08-15 22:06                   ` Maciek Machnikowski
2024-08-15 23:11                     ` Andrew Lunn
2024-08-16  4:13                       ` Maciek Machnikowski
2024-08-17  4:29                     ` Richard Cochran
2024-08-15  3:33       ` Richard Cochran
2024-08-15  4:16         ` Richard Cochran
2024-08-15  5:24           ` Miroslav Lichvar
2024-08-15  9:45             ` Maciek Machnikowski
2024-08-15  9:41           ` Maciek Machnikowski
2024-08-15  0:41 ` Jakub Kicinski
2024-08-15  3:42   ` Richard Cochran
2024-08-15  4:17     ` Richard Cochran
2024-08-15  9:35   ` Maciek Machnikowski
2024-08-15 10:29     ` Vadim Fedorenko
2024-08-15 11:40       ` Arinzon, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb35444-3508-4f77-9c66-22acf808b93c@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=darinzon@amazon.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=maciek@machnikowski.net \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.