All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 0/3] Add support for ftm responder configuration
Date: Wed, 22 Aug 2018 11:22:49 -0700	[thread overview]
Message-ID: <4fb78fad97704c8b3b1433085355180c@codeaurora.org> (raw)
In-Reply-To: <1534922856.25523.60.camel@sipsolutions.net>

On 2018-08-22 00:27, Johannes Berg wrote:
> On Tue, 2018-08-21 at 15:08 -0700, Pradeep Kumar Chitrapu wrote:
> 
>> > Right. However, I guess we could allow updating/changing this setting
>> > on
>> > the fly through () which already allows changing
>> > other
>> > non-beacon parameters (like the probe or assoc response templates), and
>> > then we can use your approach. Basically changing "SET_BEACON" to be a
>> > bit like "CHANGE_AP".
>> 
>> Agree. ( ftm_responder param will have to be added in
>> cfg80211_beacon_data
>> instead of cfg80211_ap_settings)
> 
> Right. I'm not even sure that all devices can disable it though, so we
> may be in a bind here? I think ours (Intel) can't, for example, disable
> FTM responder without disabling the AP (at least momentarily)...
> 
> Should we just ignore that? Or perhaps add a separate capability for 
> it?

Yes, even we behave the same. In that case, we can go ahead now with the
capability to only enable FTM responder. If the driver wants to support
disabling option in future, at which point, the new capability can be 
added.

However, changes to nl80211_set_beacon to support enabling FTM responder
may still be needed along with start_ap, assuming that ap start will be 
issued
by different android api than enableResponder api.

Please let me know your suggestion.

> 
> Maybe there's even hardware that cannot change the elements (LCI/Civic
> location) on the fly?
> 
> johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 0/3] Add support for ftm responder configuration
Date: Wed, 22 Aug 2018 11:22:49 -0700	[thread overview]
Message-ID: <4fb78fad97704c8b3b1433085355180c@codeaurora.org> (raw)
In-Reply-To: <1534922856.25523.60.camel@sipsolutions.net>

On 2018-08-22 00:27, Johannes Berg wrote:
> On Tue, 2018-08-21 at 15:08 -0700, Pradeep Kumar Chitrapu wrote:
> 
>> > Right. However, I guess we could allow updating/changing this setting
>> > on
>> > the fly through () which already allows changing
>> > other
>> > non-beacon parameters (like the probe or assoc response templates), and
>> > then we can use your approach. Basically changing "SET_BEACON" to be a
>> > bit like "CHANGE_AP".
>> 
>> Agree. ( ftm_responder param will have to be added in
>> cfg80211_beacon_data
>> instead of cfg80211_ap_settings)
> 
> Right. I'm not even sure that all devices can disable it though, so we
> may be in a bind here? I think ours (Intel) can't, for example, disable
> FTM responder without disabling the AP (at least momentarily)...
> 
> Should we just ignore that? Or perhaps add a separate capability for 
> it?

Yes, even we behave the same. In that case, we can go ahead now with the
capability to only enable FTM responder. If the driver wants to support
disabling option in future, at which point, the new capability can be 
added.

However, changes to nl80211_set_beacon to support enabling FTM responder
may still be needed along with start_ap, assuming that ap start will be 
issued
by different android api than enableResponder api.

Please let me know your suggestion.

> 
> Maybe there's even hardware that cannot change the elements (LCI/Civic
> location) on the fly?
> 
> johannes

  reply	other threads:[~2018-08-22 18:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 22:08 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-21 22:08 ` Pradeep Kumar Chitrapu
2018-08-22  7:27 ` Johannes Berg
2018-08-22  7:27   ` Johannes Berg
2018-08-22 18:22   ` Pradeep Kumar Chitrapu [this message]
2018-08-22 18:22     ` Pradeep Kumar Chitrapu
2018-08-28  8:43     ` Johannes Berg
2018-08-28  8:43       ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2018-08-15  0:30 Pradeep Kumar Chitrapu
2018-08-15  0:30 ` Pradeep Kumar Chitrapu
2018-08-15  9:04 ` Johannes Berg
2018-08-15  9:04   ` Johannes Berg
2018-08-16  1:50   ` pradeepc
2018-08-16  1:50     ` pradeepc
2018-08-16  8:12     ` Johannes Berg
2018-08-16  8:12       ` Johannes Berg
2018-08-18  7:50       ` Pradeep Kumar Chitrapu
2018-08-18  7:50         ` Pradeep Kumar Chitrapu
2018-08-20  9:33         ` Johannes Berg
2018-08-20  9:33           ` Johannes Berg
2018-08-21 18:32           ` Pradeep Kumar Chitrapu
2018-08-21 18:32             ` Pradeep Kumar Chitrapu
2018-08-21 19:24             ` Johannes Berg
2018-08-21 19:24               ` Johannes Berg
2018-08-16  9:21     ` Kalle Valo
2018-08-16  9:21       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb78fad97704c8b3b1433085355180c@codeaurora.org \
    --to=pradeepc@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.