RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Ping-Ke Shih <pkshih@realtek.com>
> Sent: Friday, March 1, 2024 10:33 AM
> To: Fiona Klute <fiona.klute@gmx.de>; linux-wireless@vger.kernel.org
> Cc: kvalo@kernel.org; ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; pavel@ucw.cz; megi@xff.cz
> Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
> 
> 
> 
> > -----Original Message-----
> > From: Fiona Klute <fiona.klute@gmx.de>
> > Sent: Wednesday, February 28, 2024 7:55 AM
> > To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
> > Cc: Fiona Klute <fiona.klute@gmx.de>; kvalo@kernel.org; ulf.hansson@linaro.org;
> linux-mmc@vger.kernel.org;
> > pavel@ucw.cz; megi@xff.cz
> > Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
> >
> > +
> > +#define TRANS_SEQ_END                  \
> > +       {0xFFFF,                        \
> > +        RTW_PWR_CUT_ALL_MSK,           \
> > +        RTW_PWR_INTF_ALL_MSK,          \
> > +        0,                             \
> > +        RTW_PWR_CMD_END, 0, 0}
> 
> Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.

Think of this again, I prefer removing braces
#define TRANS_SEQ_END			\
	 0xFFFF,			\
	 RTW_PWR_CUT_ALL_MSK,		\
	 RTW_PWR_INTF_ALL_MSK,		\
	 0,				\
	 RTW_PWR_CMD_END, 0, 0

Then, consumers look like

static const struct rtw_pwr_seq_cmd trans_carddis_to_cardemu_8703b[] = {
	{0x0005,
	 RTW_PWR_CUT_ALL_MSK,
	 RTW_PWR_INTF_ALL_MSK,
	 RTW_PWR_ADDR_MAC,
	 RTW_PWR_CMD_WRITE, BIT(7), 0},
	{TRANS_SEQ_END},  // <=== This one will be consistent with others.
};

Ping-Ke