From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D90ED41C33 for ; Wed, 13 Nov 2024 11:24:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.835414.1251288 (Exim 4.92) (envelope-from ) id 1tBBTu-0001JP-5s; Wed, 13 Nov 2024 11:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 835414.1251288; Wed, 13 Nov 2024 11:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tBBTu-0001JI-1k; Wed, 13 Nov 2024 11:24:18 +0000 Received: by outflank-mailman (input) for mailman id 835414; Wed, 13 Nov 2024 11:24:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tBBTs-0000sg-6u for xen-devel@lists.xenproject.org; Wed, 13 Nov 2024 11:24:16 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfa05c81-a1b1-11ef-a0c7-8be0dac302b0; Wed, 13 Nov 2024 12:24:13 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-37d70df0b1aso4317261f8f.3 for ; Wed, 13 Nov 2024 03:24:13 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed99790csm18250325f8f.46.2024.11.13.03.24.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 03:24:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa05c81-a1b1-11ef-a0c7-8be0dac302b0 X-Custom-Connection: eyJyZW1vdGVpcCI6IjJhMDA6MTQ1MDo0ODY0OjIwOjo0MzAiLCJoZWxvIjoibWFpbC13cjEteDQzMC5nb29nbGUuY29tIn0= X-Custom-Transaction: eyJpZCI6ImNmYTA1YzgxLWExYjEtMTFlZi1hMGM3LThiZTBkYWMzMDJiMCIsInRzIjoxNzMxNDk3MDUzLjg1MzM4Niwic2VuZGVyIjoiamJldWxpY2hAc3VzZS5jb20iLCJyZWNpcGllbnQiOiJ4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcifQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731497053; x=1732101853; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=CUEMOdNO3pDHYjHZvL7Na3rFQHXALDVHjrXZIk91uEg=; b=HJTFp/zxqerWBAK2fvEMuXPRzg/NtHvDGwGUQvdVvnHuVHEm2PR2JvEYB0vawGZXhX Rc8ycY9SzvhHcInDe3SlozsZKEo2lQrqS4IYXUgtHOX+0VOqsX8TrzbmpJpzAVPGMYVw oOE2p+m/7LlJQUwLLLyW1qaJWMN31km6W+yqdrtoETefO+SRZEiWcDWV3Tfrrm/zhZnZ O8TIWKNrqv24JOZkVh+WX+pNKICz2/3PaycSHP3zWn3vnHp1QrZosHY5oLISGZmEBZu1 mSslIVfQSD6/q6aZurMCtZxoDcNmM37xMCPOzN3gQAVyCFizHk0t+k7ldpZrqFRgMIm2 L6Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731497053; x=1732101853; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CUEMOdNO3pDHYjHZvL7Na3rFQHXALDVHjrXZIk91uEg=; b=axJFp00He55FKhmv0U6QVO/D8Cdv1GYCs5Q/Awp5+Kwf7hHwmPlGeIWc2BPumo3TI+ tVv8IF8XVfDCoG+s8eXHXUXhGfCrhHfPM+sUwdv4VB6lWQh/y+pwK+dzKBzz6U5SSD5T AnuodinIyfy/dlJORJvlViiJA+uSRubzOtFKDZo+FboSMcz9QZuSNBiJ9JwECzCyaxwp prsYDFxsD8ffhJhZyfvJ4r8jDIqzngBxK+m4cdHkMTQYFKcwmlpVoS456O2IVrQoX6Fn ZLLKFv3sDyCWnpUFbtnxFZ2ZeBoo63TR8mrBTeJGM34kBVd0Rd8BWhgqmXlEqY6OGP81 Eu7g== X-Forwarded-Encrypted: i=1; AJvYcCW+lYxj/sZoULTPKzLJTV9NbSNQxkmlAPKU39FefIGASbtn9qLHtFJQOgCRwWjikCPEPicPqjT/fU8=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx1UTF3zBhM0ejJ9ASLSDBh84gc1twVvv9MgogPLSoi6yFwvJlB scsjaExcshZgoVtZAhte3TJFe6tDKktSId0Cb9zhc6MvGxchJNLmwlUfl74GCA== X-Google-Smtp-Source: AGHT+IGGn+zVUSrJ+CGKWxd1a6Nh7AZ9b9QJ94a5hjEIxS3gZw9aMSngoLDJdxMvAwSEmpdGXjCcPQ== X-Received: by 2002:a5d:5f93:0:b0:37d:493c:f7b8 with SMTP id ffacd0b85a97d-381f1867129mr16831314f8f.2.1731497053160; Wed, 13 Nov 2024 03:24:13 -0800 (PST) Message-ID: <4fca3f1d-2b5f-4353-86bd-64488e12ca72@suse.com> Date: Wed, 13 Nov 2024 12:24:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] x86/trampoline: Document how the trampoline is laid out To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "Daniel P . Smith" , Frediano Ziglio , Alejandro Vallejo , Xen-devel References: <20241113093058.1562447-1-andrew.cooper3@citrix.com> <20241113093058.1562447-2-andrew.cooper3@citrix.com> <5f58dda2-1619-4416-b711-c600367d6f47@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13.11.2024 12:19, Andrew Cooper wrote: > On 13/11/2024 10:20 am, Jan Beulich wrote: >> On 13.11.2024 10:30, Andrew Cooper wrote: >>> This is, to the best of my knowledge, accurate. I am providing no comment on >>> how sane I believe it to be. >>> >>> At the time of writing, the sizes of the regions are: >>> >>> offset size >>> AP: 0x0000 0x00b0 >>> S3: 0x00b0 0x0140 >>> Boot: 0x01f0 0x1780 >>> Heap: 0x1970 0xe690 >>> Stack: 0xf000 0x1000 >>> >>> and wakeup_stack overlays boot_edd_info. >>> >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: Roger Pau Monné >>> CC: Daniel P. Smith >>> CC: Frediano Ziglio >>> CC: Alejandro Vallejo >>> --- >>> xen/arch/x86/include/asm/trampoline.h | 55 ++++++++++++++++++++++++++- >>> 1 file changed, 53 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/x86/include/asm/trampoline.h b/xen/arch/x86/include/asm/trampoline.h >>> index 8c1e0b48c2c9..d801bea400dc 100644 >>> --- a/xen/arch/x86/include/asm/trampoline.h >>> +++ b/xen/arch/x86/include/asm/trampoline.h >>> @@ -37,12 +37,63 @@ >>> * manually as part of placement. >>> */ >>> >>> +/* >>> + * Layout of the trampoline. Logical areas, in ascending order: >>> + * >>> + * 1) AP boot: >>> + * >>> + * The INIT-SIPI-SIPI entrypoint. This logic is stack-less so the identity >>> + * mapping (which must be executable) can at least be Read Only. >>> + * >>> + * 2) S3 resume: >>> + * >>> + * The S3 wakeup logic may need to interact with the BIOS, so needs a >>> + * stack. The stack pointer is set to trampoline_phys + 4k and clobbers an >>> + * undefined part of the the boot trampoline. The stack is only used with >>> + * paging disabled. >>> + * >>> + * 3) Boot trampoline: >>> + * >>> + * This region houses various data used by the AP/S3 paths too. >> This is confusing to have here - isn't the boot part (that isn't in the >> same page as the tail of the AP/S3 region) being boot-time only, and hence >> unavailable for S3 and post-boot AP bringup? Both here and with the numbers >> in the description - what position did you use as separator between 2) and >> 3)? >> >> Then again it may be just me who is confused: Didn't we, at some point, limit >> the resident trampoline to just one page? Was that only a plan, or a patch >> that never was committed? > > The positioning of various things is rather complicated. > > Only a single 4k page is mapped into idle_pg_table[]. > > But, the AP/S3 path use: >   trampoline_cpu_started >   idt_48 >   gdt_48 >   trampoline_xen_phys_start >   trampoline_misc_enable_off >   trampoline_efer > > Which is beyond the content of wakeup.S.  The GDT in particular needs to > stay valid with paging enabled, to load __HYPERVISOR_CS. > > We have /* From here on early boot only. */ in trampoline.S but that > seems to be the extent of checking.  Everything needed for AP/S3 is in > the first 0x229. > > I'm open to suggestions for how to describe this better, although the > left hand side of the diagram is already very busy. > > I suppose I could do AP+S3 as a single section, along their combined data? If by this you mean to then also cover what the first sentence of 3) said, then yes, that might be preferable. Jan