From: Pavel Begunkov <asml.silence@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [isilence:iou/discard 13/13] block/ioctl.c:206 blkdev_cmd_queue_discard() error: we previously assumed 'bio' could be null (see line 199)
Date: Fri, 2 Aug 2024 13:00:25 +0100 [thread overview]
Message-ID: <4fd1416a-8bf3-460a-9ee5-e6b81092cc98@gmail.com> (raw)
In-Reply-To: <57ef3d11-2560-4e3c-b312-63e535027dce@suswa.mountain>
On 7/31/24 17:05, Dan Carpenter wrote:
...
> 444b80e47399c0 Pavel Begunkov 2024-07-20 196 while (1) {
> 444b80e47399c0 Pavel Begunkov 2024-07-20 197 bio = blk_alloc_discard_bio(bdev, §or, &nr_sects,
> 444b80e47399c0 Pavel Begunkov 2024-07-20 198 GFP_KERNEL);
> 444b80e47399c0 Pavel Begunkov 2024-07-20 @199 if (!bio)
> 444b80e47399c0 Pavel Begunkov 2024-07-20 200 break;
>
> If we hit this break
>
> 444b80e47399c0 Pavel Begunkov 2024-07-20 201 if (nowait)
> 444b80e47399c0 Pavel Begunkov 2024-07-20 202 bio->bi_opf |= REQ_NOWAIT;
> 444b80e47399c0 Pavel Begunkov 2024-07-20 203 prev = bio_chain_and_submit(prev, bio);
> 444b80e47399c0 Pavel Begunkov 2024-07-20 204 }
> 444b80e47399c0 Pavel Begunkov 2024-07-20 205
> 444b80e47399c0 Pavel Begunkov 2024-07-20 @206 bio->bi_private = cmd;
> ^^^^^
> We are dead
Right, thanks for letting know
> 444b80e47399c0 Pavel Begunkov 2024-07-20 207 bio->bi_end_io = end_io;
> 444b80e47399c0 Pavel Begunkov 2024-07-20 208
> 444b80e47399c0 Pavel Begunkov 2024-07-20 209 if (nr_sects) {
> 444b80e47399c0 Pavel Begunkov 2024-07-20 210 bio->bi_status = BLK_STS_AGAIN;
--
Pavel Begunkov
next prev parent reply other threads:[~2024-08-02 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 16:05 [isilence:iou/discard 13/13] block/ioctl.c:206 blkdev_cmd_queue_discard() error: we previously assumed 'bio' could be null (see line 199) Dan Carpenter
2024-08-02 12:00 ` Pavel Begunkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-31 15:25 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd1416a-8bf3-460a-9ee5-e6b81092cc98@gmail.com \
--to=asml.silence@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.