From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: rawal.abhishek92@gmail.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: arawal@redhat.com, jamie.bainbridge@gmail.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: Advertise software timestamp information.
Date: Tue, 14 Oct 2025 12:05:51 +0100 [thread overview]
Message-ID: <4ffafe38-3521-4af6-810b-d9fbfe0e2020@linux.dev> (raw)
In-Reply-To: <20251014055234.46527-1-rawal.abhishek92@gmail.com>
On 14/10/2025 06:52, rawal.abhishek92@gmail.com wrote:
> From: Abhishek Rawal <rawal.abhishek92@gmail.com>
>
> Driver calls skb_tx_timestamp(skb) in rtl8152_start_xmit(), but does not advertise the capability in ethtool.
> Advertise software timestamp capabilities on struct ethtool_ops.
>
> Signed-off-by: Abhishek Rawal <rawal.abhishek92@gmail.com>
> Reviewed-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
> ---
> drivers/net/usb/r8152.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 44cba7acfe7d9bfbcc96a1e974762657bd1c3c33..f896e9f28c3b0ce2282912c9ea37820160df3a45 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -9311,6 +9311,7 @@ static const struct ethtool_ops ops = {
> .set_ringparam = rtl8152_set_ringparam,
> .get_pauseparam = rtl8152_get_pauseparam,
> .set_pauseparam = rtl8152_set_pauseparam,
> + .get_ts_info = ethtool_op_get_ts_info,
> };
>
> static int rtl8152_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2025-10-14 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 5:52 [PATCH net-next] r8152: Advertise software timestamp information rawal.abhishek92
2025-10-14 11:05 ` Vadim Fedorenko [this message]
2025-10-15 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ffafe38-3521-4af6-810b-d9fbfe0e2020@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=arawal@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jamie.bainbridge@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rawal.abhishek92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.