From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:b00f:b0:9d0:bf65:29fa with SMTP id v15csp421762ejy; Tue, 21 Nov 2023 04:15:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtWy0Jph/FrKNXQwTyapaUx3cYP2g7JeBmSgCRSlYzDMVSt2G6xu4xTtqLj31Gibn0Sozm X-Received: by 2002:a05:6214:21e4:b0:672:5946:ffe7 with SMTP id p4-20020a05621421e400b006725946ffe7mr11799150qvj.30.1700568931336; Tue, 21 Nov 2023 04:15:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700568931; cv=none; d=google.com; s=arc-20160816; b=T0aRGIfXlN3UEQKt9g2oudXEwIEFC2vbvLr+FjShagSQ9RLHQI5vN8LpMDNc72DsjZ uwUQFGNMecOT+3L4dwrImJrelYfINB0SP7ya6FxSJ7wTnUT9zzog5iPZNApyEchm5sIL Sm/WuyfUweP0l1y4UTHQ9oaIxrWcqXGCWkG6kxbzNwtlDBptMdzfERqNjXUFvqJRmnQK nRZJs6wV4d8qPJr9DEew9orUHg+6Hrb2O7GqFWXzY7/cVXL/IK/YSThK4/Wfc2Hs9teg meO7kfpbdJSPND4FrsPzNfm+0gAeyd0jlz0QSlUsnU95+6RFZqjwX9nLaldvylhVPyhm Ii7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:in-reply-to:references:user-agent:subject :cc:to:from:date:dkim-signature; bh=NpLx8dxJzqRjqYZvQ1tqeqGFEDximu0aVnXwrBcJhpM=; fh=A6d4BJTkcO4Tb4V34rr2mSX3341RstIj7VsNiQUca0w=; b=UNFwtNzPjUuWd7Be8/HzhGa3C/WLOSmxjS+Uo6+OZTjOV1NbapAHVrBJXHb29dj/pF Fc5rkjYSMwQMuX40eGG92hfuI2ot6fuaWdvGjuAYwQIJ9L5FhrMQAEsDOgRoLvCad3mR bMsqMMEU1gbLHcC5ufb+42BXp84Ygkt2cYEjCYFEyV9Y1kH4lllT7j6yJwPvBaWwHrH3 +TLw1yiHGPBTawtZ73cFGC2osu3a7r1ptUOcJyI4kg7QGnRvBjqbeExShrlVmrnOgfKX 9RAcFh6SBd2atFH03cRdroPLstXr0nfOOtV4Q5U59iO1+e1bzkF6veKOb+Z1SoGwmyM3 wcHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FrcSqaPd; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 5-20020a0562140cc500b006781b69a65dsi7060655qvx.410.2023.11.21.04.15.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Nov 2023 04:15:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FrcSqaPd; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5Pem-0003YK-2t; Tue, 21 Nov 2023 07:15:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Pek-0003Y2-5L for qemu-devel@nongnu.org; Tue, 21 Nov 2023 07:15:06 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5Peh-0002UB-Bp for qemu-devel@nongnu.org; Tue, 21 Nov 2023 07:15:05 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40859dee28cso27209155e9.0 for ; Tue, 21 Nov 2023 04:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700568901; x=1701173701; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to :references:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=NpLx8dxJzqRjqYZvQ1tqeqGFEDximu0aVnXwrBcJhpM=; b=FrcSqaPdns9Aw2+bp7LUs7YDL71u3b2mJqNdNNxcKQA/mnO2eXlJ6qENWP4M40m0nt dUa3q6J/K0pSEPwO/Yw6WupOCh7JPD1Ux4VQrLPu2ENDLOMAdcx1sJBMa3YjSW9yqeO0 xjbfERrRMqO2C0w/puMjlnKqCJF4EUYdivWlzE0wAWgTXqtXMOjDXKqaLXIhlVx0wuhT JMfFd6s/4p6PH3niiy6yhm6Md453UyKAVwPxVW8Vq+i4BsuPDKmztwCbIM1TEJEL4Pjg SgXkURxfGihN5jPmLF6qVl99YJ8uQuetI30JnDtxY+ProlrGq8LmY4UzYLBWPTfn3zlq qJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700568901; x=1701173701; h=content-transfer-encoding:mime-version:message-id:in-reply-to :references:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NpLx8dxJzqRjqYZvQ1tqeqGFEDximu0aVnXwrBcJhpM=; b=COvmtOKtuNGiDmv02ZcH1JpGItvw+ihw0mkxJcM4fH1kxd21aOAHreIkV0K73b4cLB 9hMEh18EZ/Ac1DjyIPeq2YRoFjEgH6GN5DFaSlPvmPzNnAJtXLN2AZdHbguAKc81gzfv Gz8Ut8QvnrRAj5Lmc4h5D5X4Cq2XxtBq86U10LfJrq9n//z9MScpAxY6payT+7lp+g8g J4lLLfbAmNsnPot5qDMBlRb1BtA7uvllLxTRG2qju/oLfgDzfLEyF4LwDUncHolHWcSg 8cRUslWr3XYgCbBYy+hq8oO4XKc+iWFlttCuSG3CTc7wBhAE6Q6U5R/lvwpT73kpn1Mo S20g== X-Gm-Message-State: AOJu0Yx0TBVt42TCfwsA30xGFkJoMfXuJBmPM4ABNBTwFM1RjnLuJHgI magdisKGiJeKrfWmvlSZrVNTMQ== X-Received: by 2002:a05:600c:1f96:b0:40a:57b3:d006 with SMTP id je22-20020a05600c1f9600b0040a57b3d006mr7962535wmb.22.1700568901498; Tue, 21 Nov 2023 04:15:01 -0800 (PST) Received: from meli.delivery (adsl-75.109.242.226.tellas.gr. [109.242.226.75]) by smtp.gmail.com with ESMTPSA id 21-20020a05600c229500b004090798d29csm16525550wmf.15.2023.11.21.04.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 04:15:01 -0800 (PST) Date: Tue, 21 Nov 2023 14:13:33 +0200 From: Manos Pitsidianakis To: qemu-arm@nongnu.org, Philippe Mathieu-Daud=?UTF-8?B?w6kg?=, qemu-devel@nongnu.org Cc: David Hildenbrand , Peter Maydell , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Mark Cave-Ayland , Markus Armbruster , Paolo Bonzini , Igor Mammedov , qemu-ppc@nongnu.org, C=?UTF-8?B?w6k=?= dric Le Goater , Philippe Mathieu-Daud=?UTF-8?B?w6kg?=, Peter Xu Bcc: Subject: Re: [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls User-Agent: meli 0.8.2 References: <20231120213301.24349-1-philmd@linaro.org> <20231120213301.24349-6-philmd@linaro.org> In-Reply-To: <20231120213301.24349-6-philmd@linaro.org> Message-ID: <4h3cz.uqlmydms81xu@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8; format=flowed Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: jxvqqj3iqOxf On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: >Mechanical change using the following coccinelle script: > >@@ >expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; >@@ >- memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); > if ( >- errp >+ !memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp) > ) { > ... > return; > } > >and removing the local Error variable. > >Signed-off-by: Philippe Mathieu-Daudé >--- > system/memory.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/system/memory.c b/system/memory.c >index 2fe4c3861b..ca05c4defa 100644 >--- a/system/memory.c >+++ b/system/memory.c >@@ -3604,11 +3604,8 @@ void memory_region_init_ram(MemoryRegion *mr, > Error **errp) > { > DeviceState *owner_dev; >- Error *err = NULL; > >- memory_region_init_ram_nomigrate(mr, owner, name, size, &err); >- if (err) { >- error_propagate(errp, err); >+ if (!memory_region_init_ram_nomigrate(mr, owner, name, size, errp)) { > return; > } > /* This will assert if owner is neither NULL nor a DeviceState. >-- >2.41.0 > Reviewed-by: Manos Pitsidianakis