From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Fri, 13 Jul 2012 07:41:02 -0500 Subject: [PATCH 00/11] make struct of_device_id.data const In-Reply-To: <1342182734-321-1-git-send-email-y> References: <1342182734-321-1-git-send-email-y> Message-ID: <5000175E.4070702@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/13/2012 07:32 AM, y at pengutronix.de wrote: > From: Uwe Kleine-K?nig > > Hello, > > this series' goal is to make struct of_device_id.data const. > Conceptually a driver must not modify the data contained there so making > it const is the right thing. > > This change might introduce warnings because drivers don't use const to > access the data pointed to by of_device_id.data. In most cases the fix > is to add some consts. > > This series (apart from adding this const in patch 10) fixes all drivers > covered by all arm defconfigs (based on v3.5-rc6). > What about other arches? Rob > There is one exception though: > drivers/regulator/twl-regulator.c (build in omap2plus_defconfig) now > issues: > > drivers/regulator/twl-regulator.c: In function 'twlreg_probe': > drivers/regulator/twl-regulator.c:1181: warning: assignment discards qualifiers from pointer target type > drivers/regulator/twl-regulator.c:1190: warning: assignment discards qualifiers from pointer target type > > that is because this driver really modifies his .of_match_table in the > precence of a traditionally probed device. > I didn't check deeply, but probably the easiest fix is to remove > traditional platform support. Don't know if omap is ready for that > though. > > And also patch 11 adds some more consts that are possible now after > patch 10. > > This series is available in my git tree at: > > git://git.pengutronix.de/git/ukl/linux.git ofdeviceiddata > > Best regards > Uwe > > Uwe Kleine-K?nig (11): > spi/imx: make spi_imx_data.devtype_data member point to const data > serial/imx: make imx_port.devdata member point to const data > ARM: cache-l2x0: add a const qualifier > misc/atmel_tc: make atmel_tc.tcb_config member point to const data > gpio/gpio-omap.c: add a const qualifier > i2c/i2c-omap: add a const qualifier > dmaengine: at_hdmac: add a few const qualifiers > spi/spi-omap2-mcspi: add a const qualifier > mmc/omap_hsmmc: add a const qualifier > of: add const to struct of_device_id.data > gpio/gpio-omap: make platformdata used as of_device_id.data const > > arch/arm/mm/cache-l2x0.c | 2 +- > drivers/dma/at_hdmac.c | 4 ++-- > drivers/gpio/gpio-omap.c | 8 ++++---- > drivers/i2c/busses/i2c-omap.c | 3 ++- > drivers/mmc/host/omap_hsmmc.c | 2 +- > drivers/spi/spi-imx.c | 2 +- > drivers/spi/spi-omap2-mcspi.c | 2 +- > drivers/tty/serial/imx.c | 2 +- > include/linux/atmel_tc.h | 2 +- > include/linux/mod_devicetable.h | 2 +- > 10 files changed, 15 insertions(+), 14 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 00/11] make struct of_device_id.data const Date: Fri, 13 Jul 2012 07:41:02 -0500 Message-ID: <5000175E.4070702@gmail.com> References: <1342182734-321-1-git-send-email-y> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1342182734-321-1-git-send-email-y> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: y@pengutronix.de Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org T24gMDcvMTMvMjAxMiAwNzozMiBBTSwgeUBwZW5ndXRyb25peC5kZSB3cm90ZToKPiBGcm9tOiBV d2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IAo+IEhl bGxvLAo+IAo+IHRoaXMgc2VyaWVzJyBnb2FsIGlzIHRvIG1ha2Ugc3RydWN0IG9mX2RldmljZV9p ZC5kYXRhIGNvbnN0Lgo+IENvbmNlcHR1YWxseSBhIGRyaXZlciBtdXN0IG5vdCBtb2RpZnkgdGhl IGRhdGEgY29udGFpbmVkIHRoZXJlIHNvIG1ha2luZwo+IGl0IGNvbnN0IGlzIHRoZSByaWdodCB0 aGluZy4KPiAKPiBUaGlzIGNoYW5nZSBtaWdodCBpbnRyb2R1Y2Ugd2FybmluZ3MgYmVjYXVzZSBk cml2ZXJzIGRvbid0IHVzZSBjb25zdCB0bwo+IGFjY2VzcyB0aGUgZGF0YSBwb2ludGVkIHRvIGJ5 IG9mX2RldmljZV9pZC5kYXRhLiBJbiBtb3N0IGNhc2VzIHRoZSBmaXgKPiBpcyB0byBhZGQgc29t ZSBjb25zdHMuCj4gCj4gVGhpcyBzZXJpZXMgKGFwYXJ0IGZyb20gYWRkaW5nIHRoaXMgY29uc3Qg aW4gcGF0Y2ggMTApIGZpeGVzIGFsbCBkcml2ZXJzCj4gY292ZXJlZCBieSBhbGwgYXJtIGRlZmNv bmZpZ3MgKGJhc2VkIG9uIHYzLjUtcmM2KS4KPiAKCldoYXQgYWJvdXQgb3RoZXIgYXJjaGVzPwoK Um9iCgo+IFRoZXJlIGlzIG9uZSBleGNlcHRpb24gdGhvdWdoOgo+IGRyaXZlcnMvcmVndWxhdG9y L3R3bC1yZWd1bGF0b3IuYyAoYnVpbGQgaW4gb21hcDJwbHVzX2RlZmNvbmZpZykgbm93Cj4gaXNz dWVzOgo+IAo+IAlkcml2ZXJzL3JlZ3VsYXRvci90d2wtcmVndWxhdG9yLmM6IEluIGZ1bmN0aW9u ICd0d2xyZWdfcHJvYmUnOgo+IAlkcml2ZXJzL3JlZ3VsYXRvci90d2wtcmVndWxhdG9yLmM6MTE4 MTogd2FybmluZzogYXNzaWdubWVudCBkaXNjYXJkcyBxdWFsaWZpZXJzIGZyb20gcG9pbnRlciB0 YXJnZXQgdHlwZQo+IAlkcml2ZXJzL3JlZ3VsYXRvci90d2wtcmVndWxhdG9yLmM6MTE5MDogd2Fy bmluZzogYXNzaWdubWVudCBkaXNjYXJkcyBxdWFsaWZpZXJzIGZyb20gcG9pbnRlciB0YXJnZXQg dHlwZQo+IAo+IHRoYXQgaXMgYmVjYXVzZSB0aGlzIGRyaXZlciByZWFsbHkgbW9kaWZpZXMgaGlz IC5vZl9tYXRjaF90YWJsZSBpbiB0aGUKPiBwcmVjZW5jZSBvZiBhIHRyYWRpdGlvbmFsbHkgcHJv YmVkIGRldmljZS4KPiBJIGRpZG4ndCBjaGVjayBkZWVwbHksIGJ1dCBwcm9iYWJseSB0aGUgZWFz aWVzdCBmaXggaXMgdG8gcmVtb3ZlCj4gdHJhZGl0aW9uYWwgcGxhdGZvcm0gc3VwcG9ydC4gRG9u J3Qga25vdyBpZiBvbWFwIGlzIHJlYWR5IGZvciB0aGF0Cj4gdGhvdWdoLgo+IAo+IEFuZCBhbHNv IHBhdGNoIDExIGFkZHMgc29tZSBtb3JlIGNvbnN0cyB0aGF0IGFyZSBwb3NzaWJsZSBub3cgYWZ0 ZXIKPiBwYXRjaCAxMC4KPiAKPiBUaGlzIHNlcmllcyBpcyBhdmFpbGFibGUgaW4gbXkgZ2l0IHRy ZWUgYXQ6Cj4gCj4gCWdpdDovL2dpdC5wZW5ndXRyb25peC5kZS9naXQvdWtsL2xpbnV4LmdpdCBv ZmRldmljZWlkZGF0YQo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFV3ZSBLbGVpbmUtS8O2 bmlnICgxMSk6Cj4gICBzcGkvaW14OiBtYWtlIHNwaV9pbXhfZGF0YS5kZXZ0eXBlX2RhdGEgbWVt YmVyIHBvaW50IHRvIGNvbnN0IGRhdGEKPiAgIHNlcmlhbC9pbXg6IG1ha2UgaW14X3BvcnQuZGV2 ZGF0YSBtZW1iZXIgcG9pbnQgdG8gY29uc3QgZGF0YQo+ICAgQVJNOiBjYWNoZS1sMngwOiBhZGQg YSBjb25zdCBxdWFsaWZpZXIKPiAgIG1pc2MvYXRtZWxfdGM6IG1ha2UgYXRtZWxfdGMudGNiX2Nv bmZpZyBtZW1iZXIgcG9pbnQgdG8gY29uc3QgZGF0YQo+ICAgZ3Bpby9ncGlvLW9tYXAuYzogYWRk IGEgY29uc3QgcXVhbGlmaWVyCj4gICBpMmMvaTJjLW9tYXA6IGFkZCBhIGNvbnN0IHF1YWxpZmll cgo+ICAgZG1hZW5naW5lOiBhdF9oZG1hYzogYWRkIGEgZmV3IGNvbnN0IHF1YWxpZmllcnMKPiAg IHNwaS9zcGktb21hcDItbWNzcGk6IGFkZCBhIGNvbnN0IHF1YWxpZmllcgo+ICAgbW1jL29tYXBf aHNtbWM6IGFkZCBhIGNvbnN0IHF1YWxpZmllcgo+ICAgb2Y6IGFkZCBjb25zdCB0byBzdHJ1Y3Qg b2ZfZGV2aWNlX2lkLmRhdGEKPiAgIGdwaW8vZ3Bpby1vbWFwOiBtYWtlIHBsYXRmb3JtZGF0YSB1 c2VkIGFzIG9mX2RldmljZV9pZC5kYXRhIGNvbnN0Cj4gCj4gIGFyY2gvYXJtL21tL2NhY2hlLWwy eDAuYyAgICAgICAgfCAgICAyICstCj4gIGRyaXZlcnMvZG1hL2F0X2hkbWFjLmMgICAgICAgICAg fCAgICA0ICsrLS0KPiAgZHJpdmVycy9ncGlvL2dwaW8tb21hcC5jICAgICAgICB8ICAgIDggKysr Ky0tLS0KPiAgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1vbWFwLmMgICB8ICAgIDMgKystCj4gIGRy aXZlcnMvbW1jL2hvc3Qvb21hcF9oc21tYy5jICAgfCAgICAyICstCj4gIGRyaXZlcnMvc3BpL3Nw aS1pbXguYyAgICAgICAgICAgfCAgICAyICstCj4gIGRyaXZlcnMvc3BpL3NwaS1vbWFwMi1tY3Nw aS5jICAgfCAgICAyICstCj4gIGRyaXZlcnMvdHR5L3NlcmlhbC9pbXguYyAgICAgICAgfCAgICAy ICstCj4gIGluY2x1ZGUvbGludXgvYXRtZWxfdGMuaCAgICAgICAgfCAgICAyICstCj4gIGluY2x1 ZGUvbGludXgvbW9kX2RldmljZXRhYmxlLmggfCAgICAyICstCj4gIDEwIGZpbGVzIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxpbmcg bGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96 bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNzCg==