All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: cody@linux.vnet.ibm.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: allow long lines in config file
Date: Fri, 13 Jul 2012 15:07:19 +0200	[thread overview]
Message-ID: <50001D87.1020708@suse.cz> (raw)
In-Reply-To: <1341964078-22594-1-git-send-email-cody@linux.vnet.ibm.com>

On 11.7.2012 01:47, cody@linux.vnet.ibm.com wrote:
> From: Cody Schafer <cody@linux.vnet.ibm.com>
> 
> For some config options (CONFIG_EXTRA_FIRMWARE, for example), the length
> of a config file line can exceed the 1024 byte buffer.
> 
> Switch from fgets to getline to fix.

getline() is not a portable function and kconfig is an essential part of
kernel build. Could you please change it to a loop over fgets that
terminates when the last character is '\n'?

Thanks,
Michal

  reply	other threads:[~2012-07-13 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 23:47 [PATCH] kconfig: allow long lines in config file cody
2012-07-13 13:07 ` Michal Marek [this message]
2012-07-13 18:27   ` [PATCH v2] " cody
2012-07-13 20:54     ` Michal Marek
2012-07-13 18:30   ` [PATCH] " cody
2012-07-13 20:39     ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50001D87.1020708@suse.cz \
    --to=mmarek@suse.cz \
    --cc=cody@linux.vnet.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.