From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
xen-devel <xen-devel@lists.xen.org>,
"anderson@redhat.com" <anderson@redhat.com>,
Jan Beulich <JBeulich@suse.com>,
"crash-utility@redhat.com" <crash-utility@redhat.com>
Subject: Re: [Xen-devel] [PATCH 1/5] xen: Always calculate max_cpus value
Date: Fri, 13 Jul 2012 15:51:23 +0100 [thread overview]
Message-ID: <500035EB.1020502@citrix.com> (raw)
In-Reply-To: <20120713131907.GB1876@host-192-168-1-59.local.net-space.pl>
On 13/07/12 14:19, Daniel Kiper wrote:
> On Thu, Jul 05, 2012 at 04:56:39PM +0100, Jan Beulich wrote:
>>>>> On 05.07.12 at 17:00, Daniel Kiper <daniel.kiper@oracle.com> wrote:
>>> max_cpus is not available since 20374 changeset (Miscellaneous data
>>> placement adjustments). It was moved to __initdata section. This section
>>> is freed after Xen initialization. Assume that max_cpus is always
>>> equal to XEN_HYPER_SIZE(cpumask_t) * 8.
>> Using nr_cpu_ids, when available, would seem a better fit. And
> Hmmm... I could not find such animal in Xen source code.
> However, maybe I missed something.
nr_cpu_ids was introduced into xen-unstable with c/s 23982:511d5e65a302
It is not present in 4.1 or earlier.
~Andrew
>
>> I donm't see why, on dumps from old hypervisors, you wouldn't
>> want to continue using max_cpus. Oh, wait, I see - you would
>> have to be able to tell whether it actually sits in .init.data, which
>> might not be strait forward.
> Yep, but I will try to improve that once again.
>
> Daniel
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-07-13 14:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:58 [PATCH 0/5] crash: Small bundle of fixes for Xen Daniel Kiper
2012-07-05 14:58 ` Daniel Kiper
2012-07-05 15:00 ` [PATCH 1/5] xen: Always calculate max_cpus value Daniel Kiper
2012-07-05 15:00 ` Daniel Kiper
2012-07-05 15:56 ` [Xen-devel] " Jan Beulich
2012-07-05 15:56 ` Jan Beulich
2012-07-13 13:19 ` Daniel Kiper
2012-07-13 13:19 ` [Xen-devel] " Daniel Kiper
2012-07-13 14:51 ` Andrew Cooper [this message]
2012-07-13 14:51 ` Andrew Cooper
2012-07-05 15:01 ` [PATCH 2/5] xen: Read only crash notes for onlined CPUs Daniel Kiper
2012-07-05 15:01 ` Daniel Kiper
2012-07-05 15:02 ` [PATCH 3/5] x86/xen: Read variables from dynamically allocated per_cpu data Daniel Kiper
2012-07-05 15:02 ` Daniel Kiper
2012-07-05 15:03 ` [PATCH 4/5] xen: Get idle data from alternative source Daniel Kiper
2012-07-05 15:03 ` Daniel Kiper
2012-07-05 15:04 ` [PATCH 5/5] xen: Read data correctly from dynamically allocated console ring too Daniel Kiper
2012-07-05 15:04 ` Daniel Kiper
2012-07-05 15:15 ` [PATCH 0/5] crash: Small bundle of fixes for Xen Dave Anderson
2012-07-05 15:15 ` Dave Anderson
2012-07-05 15:29 ` Daniel Kiper
2012-07-05 15:29 ` Daniel Kiper
2012-07-05 15:33 ` Konrad Rzeszutek Wilk
2012-07-05 15:33 ` Konrad Rzeszutek Wilk
2012-07-05 17:06 ` Dave Anderson
2012-07-05 17:06 ` Dave Anderson
2012-07-05 19:20 ` Dave Anderson
2012-07-05 19:20 ` Dave Anderson
2012-07-05 15:39 ` Dave Anderson
2012-07-05 15:39 ` Dave Anderson
2012-07-05 15:51 ` Daniel Kiper
2012-07-05 15:51 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500035EB.1020502@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=anderson@redhat.com \
--cc=crash-utility@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.