From: Khalid Aziz <khalid.aziz@hp.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
mikew@google.com, keescook@chromium.org,
gong.chen@linux.intel.com
Subject: Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs
Date: Fri, 13 Jul 2012 11:52:15 -0600 [thread overview]
Message-ID: <5000604F.80804@hp.com> (raw)
In-Reply-To: <20120713154645.GA16059@srcf.ucam.org>
On 07/13/2012 09:46 AM, Matthew Garrett wrote:
> I know you're just following the pattern of the existing code, but could
> you change these to be more like
>
> if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)
>
> while you're at it? I think that'd be a worthwhile cleanup.
>
I just sent out an updated patch with this change. The constant names
for EFI variable attribute are pretty darn long and cause line wrap
fairly quickly. I would like to rename those constants from EFI_VARIABLE_*
to EFI_VAR_* and possibly shorten the overall name as well:
EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV
EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT
EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME
EFI_VARIABLE_HARDWARE_ERROR_RECORD -> EFI_VAR_HW_ERROR
EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_AUTH_WRITE
EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_TIMED_AUTH_WRITE
EFI_VARIABLE_APPEND_WRITE -> EFI_VAR_APPEND
Sounds reasonable?
--
Khalid Aziz
khalid.aziz@hp.com
next prev parent reply other threads:[~2012-07-13 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 15:38 [PATCH] Add missing attributes to EFI variable attribute print out from sysfs Khalid Aziz
2012-07-13 15:44 ` Kees Cook
2012-07-13 15:46 ` Matthew Garrett
2012-07-13 15:54 ` Khalid Aziz
2012-07-13 17:52 ` Khalid Aziz [this message]
2012-07-13 17:54 ` Matthew Garrett
2012-07-13 18:05 ` Khalid Aziz
[not found] ` <CAGTjWtA0LmQ-90zjYf0nho_LEra8nx32M1R7E6o=3S68UjfEHw@mail.gmail.com>
2012-07-13 19:10 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5000604F.80804@hp.com \
--to=khalid.aziz@hp.com \
--cc=gong.chen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg59@srcf.ucam.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.