From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpoyF-0008Ge-6S for qemu-devel@nongnu.org; Fri, 13 Jul 2012 19:08:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpoyE-0004Gt-4d for qemu-devel@nongnu.org; Fri, 13 Jul 2012 19:08:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpoyD-0004Ga-T9 for qemu-devel@nongnu.org; Fri, 13 Jul 2012 19:08:22 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6DN8KKV022608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Jul 2012 19:08:20 -0400 Message-ID: <5000AAAB.5000003@redhat.com> Date: Sat, 14 Jul 2012 01:09:31 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1339575768-2557-1-git-send-email-lersek@redhat.com> <1339575768-2557-6-git-send-email-lersek@redhat.com> <20120713135136.049b9e54@doriath.home> <5000A5DA.9050904@redhat.com> In-Reply-To: <5000A5DA.9050904@redhat.com> Content-Type: multipart/mixed; boundary="------------030102010302020804040702" Subject: Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------030102010302020804040702 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 07/14/12 00:48, Laszlo Ersek wrote: > You're right. opts_do_parse() makes an exception with "id" and doesn't > call opt_set() for any occurrence of it. Would you accept the attached > fix, split up and squashed into previous parts appropriately? Sigh. I haven't looked at this code in a month, I obviously forgot to release memory symmetrically. Sorry. Laszlo --------------030102010302020804040702 Content-Type: text/plain; name="0002-OptsVisitor-release-fake_id_opt-symmetrically.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-OptsVisitor-release-fake_id_opt-symmetrically.patch" >>From 6ad7336a79f0187f4d0fba1f2f2eee64349cb137 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Sat, 14 Jul 2012 01:03:10 +0200 Subject: [PATCH 2/2] OptsVisitor: release "fake_id_opt" symmetrically Signed-off-by: Laszlo Ersek --- qapi/opts-visitor.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index a261cf3..ee6cf2b 100644 --- a/qapi/opts-visitor.c +++ b/qapi/opts-visitor.c @@ -130,6 +130,8 @@ opts_end_struct(Visitor *v, Error **errp) } g_hash_table_destroy(ov->unprocessed_opts); ov->unprocessed_opts = NULL; + g_free(ov->fake_id_opt); + ov->fake_id_opt = NULL; } -- 1.7.1 --------------030102010302020804040702--