From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SqUaU-00085f-Kh
	for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:34:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SqUaT-0002aA-OH
	for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:34:38 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:57779)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SqUaT-0002a2-Hn
	for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:34:37 -0400
Message-ID: <50031B49.1060804@weilnetz.de>
Date: Sun, 15 Jul 2012 21:34:33 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1342383931-11594-1-git-send-email-vapier@gentoo.org>
In-Reply-To: <1342383931-11594-1-git-send-email-vapier@gentoo.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for
	HOST_LONG_BITS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Frysinger <vapier@gentoo.org>
Cc: qemu-devel@nongnu.org

Am 15.07.2012 22:25, schrieb Mike Frysinger:
> This file uses the define HOST_LONG_BITS, but doesn't explicitly include
> qemu-common.h for it leading to build warnings for some setups:
> In file included from qemu/target-bfin/cpu.h:17,
>                   from qemu/cputlb.c:21:
> qemu/cpu-defs.h:83:5: warning: "HOST_LONG_BITS" is not defined
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>   cpu-defs.h |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/cpu-defs.h b/cpu-defs.h
> index f49e950..0d6018d 100644
> --- a/cpu-defs.h
> +++ b/cpu-defs.h
> @@ -28,6 +28,7 @@
>   #include <inttypes.h>
>   #include <signal.h>
>   #include "osdep.h"
> +#include "qemu-common.h"
>   #include "qemu-queue.h"
>   #include "targphys.h"


No. Of course this works, but I don't think that it is reasonable
to include qemu-common.h in every *.h file. There are already too
many of them.

target-bfin/cpu.h should start like all other cpu.h files with
these include statements:

#include "config.h"
#include "qemu-common.h"

Regards,

Stefan Weil