From: rob@landley.net (Rob Landley)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/1] clk: add DT support for clock gating control
Date: Sun, 15 Jul 2012 15:45:42 -0500 [thread overview]
Message-ID: <50032BF6.9000704@landley.net> (raw)
In-Reply-To: <4FFFED7C.9050406@googlemail.com>
I believe clock anything is Thomas Gleixner, just making sure he's seen
it...
Rob
On 07/13/2012 04:42 AM, Sebastian Hesselbarh wrote:
> On 07/13/2012 05:19 AM, Rob Herring wrote:
>> What's implemented in Linux should not define the binding. The binding
>> should describe the hardware.
>> [...]
>> True, but not your problem to implement. A binding doesn't necessarily
>> mean there is a full Linux implementation. We just don't want to create
>> something only to find others need something completely different.
>
> Ok, what about a DT describing the following for a simple register-based
> clock gating controller and the corresponding gated-clock independent of
> the controller. I am sure there are a bunch of SoCs out there that
> control their clock gates by writing some bits to a register. If that
> DT description matches your expectations, I ll prepare patches with
> documentation and implementation for common clock framework.
>
> Sebastian
>
> --
> /* Simple clock gating controller based on bitmasks and register */
> cgc: clock-gating-control at f1000000 {
> compatible = "clock-gating-control-register";
> reg = <0xf1000000 0x4>;
>
> /* Clock gating control with one bit at bit position 0
> enable with (1<<0), disable with (0<<0) */
> cgctrl_usb0: cgc_usb0 {
> clock-gating-control,shift = <0>;
> clock-gating-control,mask = <1>;
> clock-gating-control,enable = <1>;
> clock-gating-control,disable = <0>;
> };
>
> /* Clock gating control with two bits at bit position 1-2
> enable with (2<<1), disable with (0<<1) */
> cgctrl_sata: cgc_sata {
> clock-gating-control,shift = <1>;
> clock-gating-control,mask = <3>;
> clock-gating-control,enable = <2>;
> clock-gating-control,disable = <0>;
> };
> };
>
> /* Generic clock gate description that can be used with
> any clock gating controller */
> cg_usb0: clockgate at 0 {
> compatible = "gated-clock";
> #clock-cells = <0>;
> clocks = <&osc>;
> clock-gate-control = <&cgctrl_usb0>;
> };
>
--
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation. Pick one.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net>
To: Sebastian Hesselbarh <sebastian.hesselbarth@googlemail.com>
Cc: Rob Herring <robherring2@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Mike Turquette <mturquette@ti.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tglx@linutronix.de
Subject: Re: [RESEND PATCH 1/1] clk: add DT support for clock gating control
Date: Sun, 15 Jul 2012 15:45:42 -0500 [thread overview]
Message-ID: <50032BF6.9000704@landley.net> (raw)
In-Reply-To: <4FFFED7C.9050406@googlemail.com>
I believe clock anything is Thomas Gleixner, just making sure he's seen
it...
Rob
On 07/13/2012 04:42 AM, Sebastian Hesselbarh wrote:
> On 07/13/2012 05:19 AM, Rob Herring wrote:
>> What's implemented in Linux should not define the binding. The binding
>> should describe the hardware.
>> [...]
>> True, but not your problem to implement. A binding doesn't necessarily
>> mean there is a full Linux implementation. We just don't want to create
>> something only to find others need something completely different.
>
> Ok, what about a DT describing the following for a simple register-based
> clock gating controller and the corresponding gated-clock independent of
> the controller. I am sure there are a bunch of SoCs out there that
> control their clock gates by writing some bits to a register. If that
> DT description matches your expectations, I ll prepare patches with
> documentation and implementation for common clock framework.
>
> Sebastian
>
> --
> /* Simple clock gating controller based on bitmasks and register */
> cgc: clock-gating-control@f1000000 {
> compatible = "clock-gating-control-register";
> reg = <0xf1000000 0x4>;
>
> /* Clock gating control with one bit at bit position 0
> enable with (1<<0), disable with (0<<0) */
> cgctrl_usb0: cgc_usb0 {
> clock-gating-control,shift = <0>;
> clock-gating-control,mask = <1>;
> clock-gating-control,enable = <1>;
> clock-gating-control,disable = <0>;
> };
>
> /* Clock gating control with two bits at bit position 1-2
> enable with (2<<1), disable with (0<<1) */
> cgctrl_sata: cgc_sata {
> clock-gating-control,shift = <1>;
> clock-gating-control,mask = <3>;
> clock-gating-control,enable = <2>;
> clock-gating-control,disable = <0>;
> };
> };
>
> /* Generic clock gate description that can be used with
> any clock gating controller */
> cg_usb0: clockgate@0 {
> compatible = "gated-clock";
> #clock-cells = <0>;
> clocks = <&osc>;
> clock-gate-control = <&cgctrl_usb0>;
> };
>
--
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation. Pick one.
next prev parent reply other threads:[~2012-07-15 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 7:15 [RESEND PATCH 1/1] clk: add DT support for clock gating control Sebastian Hesselbarth
2012-07-12 7:15 ` Sebastian Hesselbarth
2012-07-12 12:14 ` Rob Herring
2012-07-12 12:14 ` Rob Herring
2012-07-12 13:08 ` Sebastian Hesselbarh
2012-07-12 13:08 ` Sebastian Hesselbarh
2012-07-13 3:19 ` Rob Herring
2012-07-13 3:19 ` Rob Herring
2012-07-13 9:42 ` Sebastian Hesselbarh
2012-07-13 9:42 ` Sebastian Hesselbarh
2012-07-14 5:00 ` Rob Herring
2012-07-14 5:00 ` Rob Herring
2012-07-14 5:00 ` Rob Herring
2012-07-15 20:45 ` Rob Landley [this message]
2012-07-15 20:45 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50032BF6.9000704@landley.net \
--to=rob@landley.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.