From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqdpe-0005bf-OX for qemu-devel@nongnu.org; Mon, 16 Jul 2012 01:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sqdpd-0005UL-LC for qemu-devel@nongnu.org; Mon, 16 Jul 2012 01:26:54 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:35377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqdpd-0005U4-EZ for qemu-devel@nongnu.org; Mon, 16 Jul 2012 01:26:53 -0400 Message-ID: <5003A61A.7080500@weilnetz.de> Date: Mon, 16 Jul 2012 07:26:50 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1342383931-11594-1-git-send-email-vapier@gentoo.org> <50031B49.1060804@weilnetz.de> <201207151754.08786.vapier@gentoo.org> In-Reply-To: <201207151754.08786.vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for HOST_LONG_BITS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Frysinger Cc: qemu-devel@nongnu.org Am 15.07.2012 23:54, schrieb Mike Frysinger: > On Sunday 15 July 2012 15:34:33 Stefan Weil wrote: >> Am 15.07.2012 22:25, schrieb Mike Frysinger: >>> This file uses the define HOST_LONG_BITS, but doesn't explicitly include >>> qemu-common.h for it leading to build warnings for some setups: >>> In file included from qemu/target-bfin/cpu.h:17, >>> >>> from qemu/cputlb.c:21: >>> qemu/cpu-defs.h:83:5: warning: "HOST_LONG_BITS" is not defined >>> >>> Signed-off-by: Mike Frysinger >>> --- >>> >>> cpu-defs.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/cpu-defs.h b/cpu-defs.h >>> index f49e950..0d6018d 100644 >>> --- a/cpu-defs.h >>> +++ b/cpu-defs.h >>> @@ -28,6 +28,7 @@ >>> >>> #include >>> #include >>> #include "osdep.h" >>> >>> +#include "qemu-common.h" >>> >>> #include "qemu-queue.h" >>> #include "targphys.h" >> No. Of course this works, but I don't think that it is reasonable >> to include qemu-common.h in every *.h file. There are already too >> many of them. >> >> target-bfin/cpu.h should start like all other cpu.h files with >> these include statements: > sorry, but that's fragile junk. if a header file uses defines from another > header file, it should be including it. > -mike There are different ways how things can be done. Normally, I agree with you that each header file should be complete, but that's not the QEMU style. In your special case, it's more important to keep all */cpu.h similar. qemu/target-bfin/cpu.h is still not part of the official QEMU code, so it can be fixed before it is committed. Cheers, Stefan