From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sqeju-000258-D0
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 02:25:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sqejt-0001ob-6b
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 02:25:02 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:43946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sqejs-0001oX-Vf
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 02:25:01 -0400
Received: by wibhm2 with SMTP id hm2so1875983wib.10
	for <qemu-devel@nongnu.org>; Sun, 15 Jul 2012 23:25:00 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5003B3B9.90908@redhat.com>
Date: Mon, 16 Jul 2012 08:24:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1342383911-6094-1-git-send-email-minyard@acm.org>
	<1342383911-6094-10-git-send-email-minyard@acm.org>
In-Reply-To: <1342383911-6094-10-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when
	setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org

Il 15/07/2012 22:25, minyard@acm.org ha scritto:
> From: Corey Minyard <cminyard@mvista.com>
> 
> When setting an object, if you don't release the previous object
> that was there, it may become unusable.  This change allows a
> chardev to be removed from one object's properties and added to
> another's.
> ---
>  qom/object.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index 00bb3b0..484dc77 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -731,6 +731,8 @@ void object_property_set(Object *obj, Visitor *v, const char *name,
>      if (!prop->set) {
>          error_set(errp, QERR_PERMISSION_DENIED);
>      } else {
> +	if (prop->release)
> +	    prop->release(obj, name, prop->opaque);
>          prop->set(obj, v, prop->opaque, name, errp);
>      }
>  }
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

... but you need to run scripts/checkpatch.pl on your patches to conform
to coding style.

Thanks!

Paolo