From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 4/5] gpio: tps6586x: add gpio support through platform driver
Date: Mon, 16 Jul 2012 12:17:51 +0530 [thread overview]
Message-ID: <5003B917.9040808@nvidia.com> (raw)
In-Reply-To: <CACRpkdadrHaH0kCfn22T+GnO=TKNvexcup+TsajPgnQgkiQ9Gw@mail.gmail.com>
On Sunday 15 July 2012 03:48 AM, Linus Walleij wrote:
> On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan<ldewangan@nvidia.com> wrote:
>
>> Converting the gpio driver of tps6586x to a platform
>> driver in place of registering the gpio through core
>> driver.
>> The motivation of the change is:
>> - This is inline with the mfd drivers implementation.
>> - This will move the related gpio support to gpio driver
>> folder where all gpio related drivers are available.
>> This will be easy the maintenance and enhancement is
>> anything done for gpio.
>> - The gpio functionality can be selected through config
>> variable.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> Overall this is very, very good and you're doing the right thing.
>
>> --- /dev/null
>> +++ b/drivers/gpio/gpio-tps6586x.c
>> +#include<linux/i2c.h>
> Why?
>
Removed this inclusion as it is not require.
> Reviewed-by: Linus Walleij<linus.walleij@linaro.org>
I will add your reviewed-by in my next patch for easyness.
next prev parent reply other threads:[~2012-07-16 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 10:39 [PATCH 0/5] mfd: tp6586x: enhancements in the driver Laxman Dewangan
2012-07-13 10:39 ` [PATCH 1/5] mfd: tps6586x:use devm managed resources Laxman Dewangan
2012-07-13 10:39 ` [PATCH 2/5] mfd: Use regmap for tps6586x register access Laxman Dewangan
2012-07-13 10:39 ` [PATCH 3/5] mfd: tps6586x: cache register through regmap Laxman Dewangan
2012-07-13 10:39 ` [PATCH 4/5] gpio: tps6586x: add gpio support through platform driver Laxman Dewangan
2012-07-14 22:18 ` Linus Walleij
2012-07-16 6:47 ` Laxman Dewangan [this message]
2012-07-13 10:39 ` [PATCH 5/5] mfd: tps6586x: remove gpio support from core driver Laxman Dewangan
2012-07-14 22:12 ` Linus Walleij
2012-07-16 6:49 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5003B917.9040808@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.