From: Avi Kivity <avi@redhat.com>
To: Rusty Russell <rusty.russell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
Alexander Graf <agraf@suse.de>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [Qemu-devel] [kvmarm] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15
Date: Mon, 16 Jul 2012 11:09:01 +0300 [thread overview]
Message-ID: <5003CC1D.50400@redhat.com> (raw)
In-Reply-To: <87pq7wxje8.fsf@rustcorp.com.au>
On 07/16/2012 10:19 AM, Rusty Russell wrote:
> On Fri, 13 Jul 2012 12:06:26 +0200, Alexander Graf <agraf@suse.de> wrote:
>> > struct kvm_sregs {
>> > + __u32 target;
>> > + __u32 num_features;
>> > + __u32 features[14];
>> > };
>>
>> Are you sure you want to use sregs? We did the mistake of reusing it
>> on ppc, but that doesn't mean you need to repeat the same one :)
>>
>> Basically sregs are an x86 specific struct for its segment register
>> information. I'm quite sure that this is not what your use of them is
>> here.
>
> Since each arch is given a hook already, I just abused it. I'll change
> this to a fresh KVM_ARM_SET_TARGET ioctl.
I guess this is equivalent to KVM_SET_CPUID2 on x86. Note that's a vcpu
ioctl.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-07-16 8:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 3:37 [Qemu-devel] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15 Rusty Russell
2012-07-13 3:43 ` [Qemu-devel] [PATCH 2/3] target-arm: kvm: use KVM_GET_MSRS/KVM_SET_MSRS for CP15 registers Rusty Russell
2012-07-13 14:27 ` Blue Swirl
2012-07-13 3:43 ` [Qemu-devel] [PATCH 3/3] target-arm: kvm: remove old kernel support Rusty Russell
2012-07-13 8:06 ` [Qemu-devel] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15 Peter Maydell
2012-07-16 7:22 ` Rusty Russell
2012-07-13 10:06 ` [Qemu-devel] [kvmarm] " Alexander Graf
2012-07-16 7:19 ` Rusty Russell
2012-07-16 8:08 ` Alexander Graf
2012-07-16 8:09 ` Avi Kivity [this message]
2012-07-17 17:31 ` [Qemu-devel] " Peter Maydell
2012-07-17 18:19 ` Peter Maydell
2012-07-25 6:17 ` Rusty Russell
2012-07-25 15:04 ` Peter Maydell
2012-07-31 21:52 ` [Qemu-devel] [kvmarm] " Antonios Motakis
2012-08-01 1:53 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5003CC1D.50400@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty.russell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.