From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqgTU-0007Un-6e for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:16:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqgTJ-0006an-St for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:16:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqgTJ-0006ah-Km for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:16:01 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6G8G0YZ007136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jul 2012 04:16:01 -0400 Message-ID: <5003CDBF.80608@redhat.com> Date: Mon, 16 Jul 2012 10:15:59 +0200 From: Pavel Hrdina MIME-Version: 1.0 References: <4FFF1183.30500@redhat.com> In-Reply-To: <4FFF1183.30500@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On 07/12/2012 08:03 PM, Eric Blake wrote: > On 07/12/2012 10:55 AM, Pavel Hrdina wrote: >> Signed-off-by: Pavel Hrdina >> --- >> +++ b/qapi-schema.json >> @@ -934,6 +934,41 @@ >> { 'command': 'query-block-jobs', 'returns': ['BlockJobInfo'] } >> >> ## >> +# @SnapshotInfo: >> +# >> +# Snapshot list. This structure contains list of snapshots for virtual machine. >> +# >> +# @id: id of the snapshot. >> +# >> +# @tag: human readable tag of the snapshot. > Tag was optional on creation, should that field be marked optional and > omitted on output when there was no tag on input? If you create snapshot using an ID, Tag is created automatically. Even if it is ugly tag, I think that we shouldn't omit it on output. >> +# >> +# @vm_size: size of the snapshot in Bytes. >> +# >> +# @date: date and time of the snapshot as timestamp. > What type of timestamp? Seconds since Epoch? It is unix timestamp in seconds since Epoch. >> +# >> +# @vm_clock: time in the guest in nsecs. > If vm_clock is in nsecs, should we also be reporting sub-second > resolution in date? Well, I thought that this could be enough, but we could return the same structure as "QEMUSnapshotInfo". >> +SQMP >> +query-snapshots >> +---------- >> + >> +List available snapshots for VM. >> + >> +Return a json-object with the following information: > Returns an array of json-objects, each with the following information: >