All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
	paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cpumask: cpumask_scnprintf() comments correction
Date: Mon, 16 Jul 2012 16:29:24 +0800	[thread overview]
Message-ID: <5003D0E4.2060300@intel.com> (raw)
In-Reply-To: <87ehocxig6.fsf@rustcorp.com.au>

On 07/16/2012 03:40 PM, Rusty Russell wrote:

> On Mon, 16 Jul 2012 10:35:54 +0800, Alex Shi <alex.shi@intel.com> wrote:
>> The function has no parameter @len now, so need to remove it from
>> comments to avoid kernel-doc warning:
> 
> But it still does in my tree.
> 
> Please push this patch via whoever changed it?
> 
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> 

Sorry, my fault, the commit log used a wrong function name, it is cpulist_parse()
not cpumask_scnprntf. and find a new error in the comments: used a incorrect 
function name: cpulist_parse_user(), the correct one is cpulist_parse().
Fix it in updated patch.

Both errors appear in Rusty's commit 29c0177e6a4.

===

>From db20433a0b321f7b4edfc57f66e816d7bec81b14 Mon Sep 17 00:00:00 2001
From: Alex Shi <alex.shi@intel.com>
Date: Mon, 16 Jul 2012 10:25:06 +0800
Subject: [PATCH] cpumask: cpulist_parse() comments correction

The function has no parameter @len, so need to remove it from
comments to avoid kernel-doc warning:

alexs@debian:~/linux-next$ scripts/kernel-doc -man
include/linux/cpumask.h | split-man.pl /tmp/man
....
Warning(include/linux/cpumask.h:602): Excess function parameter 'len'
description in 'cpulist_parse'

and correct the function name in comments to cpulist_parse.

Signed-off-by: Alex Shi <alex.shi@intel.com>
---
 include/linux/cpumask.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
index 8bf1c27..0325602 100644
--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -591,9 +591,8 @@ static inline int cpulist_scnprintf(char *buf, int len,
 }
 
 /**
- * cpulist_parse_user - extract a cpumask from a user string of ranges
+ * cpulist_parse - extract a cpumask from a user string of ranges
  * @buf: the buffer to extract from
- * @len: the length of the buffer
  * @dstp: the cpumask to set.
  *
  * Returns -errno, or 0 for success.
-- 
1.7.5.4


  reply	other threads:[~2012-07-16  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16  2:35 [PATCH 2/2] cpumask: cpumask_scnprintf() comments correction Alex Shi
2012-07-16  7:40 ` Rusty Russell
2012-07-16  8:29   ` Alex Shi [this message]
2012-07-20  1:54     ` Alex Shi
2012-07-20  6:16     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5003D0E4.2060300@intel.com \
    --to=alex.shi@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.