Re: [PATCH] iio: staging: ad7298_ring: Fix maybe-uninitialized warning

[Jonathan Cameron <jic23@cam.ac.uk>]

On 7/16/2012 11:02 AM, Peter Meerwald wrote:
>
>> Well - calling a function to initialize a variable which isn't being used
>> anywhere doesn't make more sense.
>
>> IMHO a more adequate fix would be to remove the timestamp argument from
>> store_to(),
>> since it isn't used anywhere.
>
> so
> indio_dev->buffer->access->store_to(ring, (u8 *)buf, time_ns);
> should become
> iio_push_to_buffer(buffer, (u8 *)data->buffer, time_ns);
> and you suggest to drop the last argument?
>
> I wasn't aware that timestamp is not used; at least iio_store_to_kfifo()
> and iio_store_to_sw_ring() just ignore it
>
Yes. Been meaning to clean that up for a while, but as one of the
multiple buffer patches removes all those calls anyway I'll
kill it whilst doing that.