From: Alex Elder <elder@inktank.com>
To: Jiaju Zhang <jjzhang@suse.de>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] libceph: trivial fix for the incorrect debug output
Date: Mon, 16 Jul 2012 07:55:16 -0500 [thread overview]
Message-ID: <50040F34.3080909@inktank.com> (raw)
In-Reply-To: <1342334726-28541-1-git-send-email-jjzhang@suse.de>
On 07/15/2012 01:45 AM, Jiaju Zhang wrote:
> This is a trivial fix for the debug output, as it is inconsistent
> with the function name so may confuse people when debugging.
>
> Signed-off-by: Jiaju Zhang <jjzhang@suse.de>
I have been converting these to use __func__ whenever I touch
code nearby. Mind if I do that here as well?
Reviewed-by: Alex Elder <elder@inktank.com>
> ---
> net/ceph/osd_client.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 1ffebed..ad6d745 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd)
>
> static void remove_all_osds(struct ceph_osd_client *osdc)
> {
> - dout("__remove_old_osds %p\n", osdc);
> + dout("__remove_all_osds %p\n", osdc);
dout("%s %p\n", __func__, osdc);
> mutex_lock(&osdc->request_mutex);
> while (!RB_EMPTY_ROOT(&osdc->osds)) {
> struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-07-16 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 6:45 [PATCH] libceph: trivial fix for the incorrect debug output Jiaju Zhang
2012-07-16 12:55 ` Alex Elder [this message]
2012-07-16 14:41 ` Jiaju Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50040F34.3080909@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jjzhang@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.