From: Christian Kapeller <christian.kapeller@cmotion.eu>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly.
Date: Mon, 16 Jul 2012 16:31:29 +0200 [thread overview]
Message-ID: <500425C1.70107@cmotion.eu> (raw)
In-Reply-To: <20120716142524.GN30009@pengutronix.de>
On 07/16/2012 04:25 PM, Sascha Hauer wrote:
> On Mon, Jul 16, 2012 at 11:53:58AM +0200, Christian Kapeller wrote:
>>
>> diff --git a/arch/arm/boards/karo-tx51/tx51.c b/arch/arm/boards/karo-tx51/tx51.c
>> index 096683a..d862a68 100644
>> --- a/arch/arm/boards/karo-tx51/tx51.c
>> +++ b/arch/arm/boards/karo-tx51/tx51.c
>> @@ -205,6 +205,12 @@ static inline void tx51_fec_init(void)
>> }
>>
>> /*
>> + *Turn off phy power, be cautious and wait
>> + */
>> + gpio_set_value(TX51_FEC_PHY_PWR, 0);
>> + mdelay(20);
>
> Does this fix the mentioned regression due to iomuxing or is this
> another issue?
Nope, that is another issue. This fix is from my v2012.03.0 branch.
Without it the phy init worked only flaky.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-07-16 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:53 [PATCH 0/2] Misc Karo TX51 fixes Christian Kapeller
2012-07-16 9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
2012-07-16 14:25 ` Sascha Hauer
2012-07-16 14:31 ` Christian Kapeller [this message]
2012-07-16 9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
2012-07-16 14:31 ` Sascha Hauer
2012-07-16 14:41 ` Christian Kapeller
2012-07-16 15:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500425C1.70107@cmotion.eu \
--to=christian.kapeller@cmotion.eu \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.