From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqnhS-0000RK-5o for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:59:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqnhK-0005oC-6C for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:59:06 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:57424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqnhJ-0005o7-W3 for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:58:58 -0400 Message-ID: <50043A3F.5010501@weilnetz.de> Date: Mon, 16 Jul 2012 17:58:55 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <5003200B.4070400@weilnetz.de> <500435B8.2010909@redhat.com> In-Reply-To: <500435B8.2010909@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Mike Frysinger , qemu-devel@nongnu.org Am 16.07.2012 17:39, schrieb Eric Blake: > On 07/15/2012 01:54 PM, Stefan Weil wrote: >> Am 15.07.2012 22:26, schrieb Mike Frysinger: >>> We should not quote the PKG_CONFIG setting as this deviates from the >>> canonical upstream behavior that gets integrated with all other build >>> systems, and deviates from how we treat all other toolchain variables >>> that we get from the environment. >>> >>> Ultimately, the point is that it breaks passing custom flags directly >>> to pkg-config via the env var where this normally works elsewhere, >>> and it used to work in the past. >> >> >> What about passing custom flags with QEMU_PKG_CONFIG_FLAGS? >> >> Removing the quotes will not allow paths containing spaces, >> so that's not a good idea. > > Actually, it IS a good idea. The de facto standard build environment > requires that pkg-config is not allowed to live in a path containing > spaces, precisely so that you can override the variable to pass options > to your preferred location of pkg-config; and if your build setup is > truly so messed up as to have pkg-config installed in a canonical > location with spaces, then you can also tweak your unusual environment > to provide a symlink to pkg-config that does not contain spaces as the > workaround. That sounds reasonable. Then the following patch was at least partially unnecessary: commit 17884d7b6462b0fe497f08fec6091ffbe04caa8d Author: Sergei Trofimovich Date: Tue Jan 31 22:03:45 2012 +0300 ./configure: request pkg-config to provide private libs when static linking Added wrapper around pkg-config to allow: - safe options injection via ${QEMU_PKG_CONFIG_FLAGS} - spaces in path to pkg-config Signed-off-by: Sergei Trofimovich CC: Peter Maydell Signed-off-by: Anthony Liguori With Mike's new patch, QEMU_PKG_CONFIG_FLAGS is no longer needed because options can be passed using the pkg-config macro. I suggest to remove it. Regards, Stefan W.