Re: [PATCH] Fix for psplash segmentation fault

[Saul Wold <sgw@linux.intel.com>]

On 07/06/2012 01:53 PM, Aws Ismail wrote:
> Fix segmentation fault when passing -a without angel value.
>
> When psplash -a is called instead of psplash -a<angle value>
> it will segmentation fault calling out of bound argv[].
>
> git://git.yoctoproject.org/psplash
>
> Signed-of-by: Aws Ismail<aws.ismail@windriver.com>
>
> -----------------------------------------------------------------
>
> diff --git a/psplash.c b/psplash.c
> index 0158628..09cf0d0 100644
> --- a/psplash.c
> +++ b/psplash.c
> @@ -219,7 +219,7 @@ main (int argc, char** argv)
>
>         if (!strcmp(argv[i],"-a") || !strcmp(argv[i],"--angle"))
>           {
> -         if (++i > argc) goto fail;
> +         if (++i >= argc) goto fail;
>            angle = atoi(argv[i]);
>            continue;
>          }
>
Merged into psplash upstream, if you would like to send a patch to 
Openembedded-Core updating the psplash recipe that would be welcome also.

Thanks
	Sau!

> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
>