From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 16 Jul 2012 17:03:44 +0000
Subject: Re: [PATCH] openpic: Added BRR1 register
Message-Id: <50044970.2000706@freescale.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1342091277-7122-1-git-send-email-Bharat.Bhushan@freescale.com>
In-Reply-To: <1342091277-7122-1-git-send-email-Bharat.Bhushan@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ppc@vger.kernel.org

On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>> +    case 0x00: /* BRR1 */
>>> +        retval = 0x00400200;
>>
>> Please unmagicify this one :)
> 
> /* BRR1 ( Block revision register ) */
> 
> #define IPID 0x00400000 /* IP-block ID */
> #define IPMJ 0x00000200 /* IP major number */
> #define IPMN 0x00000200 /* IP minor number */

IPMN looks wrong.

-Scott