From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCHv2 2/2] ARM: socfpga: Add board support for Altera's SOCFPGA Cyclone 5 HW
Date: Mon, 16 Jul 2012 17:43:34 -0500 [thread overview]
Message-ID: <50049916.3080509@gmail.com> (raw)
In-Reply-To: <1342113976-27140-3-git-send-email-dinguyen@altera.com>
On 07/12/2012 12:26 PM, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> - Mininum support for Altera's SOCFPGA Cyclone 5 hardware.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Reviewed-by: Pavel Machek <pavel@denx.de>
Two comments below, but otherwise:
Reviewed-by: Rob Herring <rob.herring@calxeda.com>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 73 ++++++++++++++++++
> arch/arm/boot/dts/socfpga_cyclone5.dts | 118 ++++++++++++++++++++++++++++++
> arch/arm/configs/socfpga_defconfig | 83 +++++++++++++++++++++
> arch/arm/mach-socfpga/Kconfig | 7 ++
> arch/arm/mach-socfpga/Makefile | 6 ++
> arch/arm/mach-socfpga/Makefile.boot | 1 +
> arch/arm/mach-socfpga/common.h | 2 +-
> arch/arm/mach-socfpga/socfpga_cyclone5.c | 60 +++++++++++++++
I don't think this patch split makes too much sense. I would put all but
the dts files and defconfig in the first patch.
> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
> new file mode 100644
> index 0000000..133fc89
> --- /dev/null
> +++ b/arch/arm/mach-socfpga/Kconfig
> @@ -0,0 +1,7 @@
> +config MACH_SOCFPGA_CYCLONE5
> + bool "SOCFPGA Cyclone5 platform"
> + select COMMON_CLK
> + select HAVE_SMP
> + select PLAT_SOCFPGA_ETH
> + help
> + Include support for the Altera(R) Cyclone5 development platform.
You don't need a config option for a machine with DT.
Rob
next prev parent reply other threads:[~2012-07-16 22:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 17:26 [RFC PATCHv2 0/2]arm: socfpga: Add initial support for Altera's SOCFPGA HW dinguyen at altera.com
2012-07-12 17:26 ` [RFC PATCHv2 1/2] ARM: socfpga: initial support for Altera's SOCFPGA platform dinguyen at altera.com
2012-07-16 22:46 ` Rob Herring
2012-07-17 15:47 ` Arnd Bergmann
2012-07-17 21:31 ` Dinh.Nguyen
2012-07-17 21:23 ` Arnd Bergmann
2012-07-12 17:26 ` [RFC PATCHv2 2/2] ARM: socfpga: Add board support for Altera's SOCFPGA Cyclone 5 HW dinguyen at altera.com
2012-07-16 22:43 ` Rob Herring [this message]
2012-07-17 7:20 ` Thomas Petazzoni
2012-07-17 7:13 ` Thomas Petazzoni
2012-07-17 15:44 ` Dinh.Nguyen
2012-07-17 15:56 ` Arnd Bergmann
2012-07-16 21:37 ` [RFC PATCHv2 0/2]arm: socfpga: Add initial support for Altera's SOCFPGA HW Pavel Machek
2012-07-17 15:43 ` Arnd Bergmann
2012-07-17 16:46 ` Dinh.Nguyen
2012-07-18 10:35 ` Pavel Machek
2012-07-18 10:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50049916.3080509@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.