All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: linux-dtb: add multi-dtb build support
Date: Mon, 16 Jul 2012 15:48:47 -0700	[thread overview]
Message-ID: <50049A4F.2040100@linux.intel.com> (raw)
In-Reply-To: <1340682796-11569-1-git-send-email-b19537@freescale.com>

On 06/25/2012 08:53 PM, b19537@freescale.com wrote:
> From: Zhenhua Luo <b19537@freescale.com>
>
>      including following enhancement:
>      * support multi-dtb build
>      * skip dtb build and install when KERNEL_DEVICETREE is empty
>      * print a warning message when specified dts file is not available
>
> Signed-off-by: Zhenhua Luo <b19537@freescale.com>
> ---
>   meta/recipes-kernel/linux/linux-dtb.inc |   36 +++++++++++++++++++++++++------
>   1 files changed, 29 insertions(+), 7 deletions(-)
>
This patch appears to rename the .dtb file different than it did before 
this change.  Is that correct?

Seem to change it from:

uImage-mpc8315e-rdb.dtb

to

uImage-mpc8315erdb.dtb

While the .bin file is still: uImage-mpc8315e-rdb.bin

Inquiring minds??  This was filed as bug 2769

https://bugzilla.yoctoproject.org/show_bug.cgi?id=2769

Thanks
Sau!


> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index 9188cee..8aa1458 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -15,13 +15,35 @@ python __anonymous () {
>
>   do_install_append() {
>       if test -n "${KERNEL_DEVICETREE}"; then
> -	dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${KERNEL_DEVICETREE}
> -	install -m 0644 devicetree ${D}/boot/devicetree-${KERNEL_VERSION}
> -	install -d ${DEPLOYDIR}
> -	install -m 0644 devicetree ${DEPLOYDIR}/${KERNEL_IMAGE_BASE_NAME}.dtb
> -	cd ${DEPLOYDIR}
> -	rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> -	ln -sf ${KERNEL_IMAGE_BASE_NAME}.dtb ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> +        for DTS_FILE in ${KERNEL_DEVICETREE}; do
> +            if [ ! -f ${DTS_FILE} ]; then
> +                echo "Warning: ${DTS_FILE} is not available!"
> +                continue
> +            fi
> +            DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> +            DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> +            DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> +            dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o ${DTS_BASE_NAME} ${DTS_FILE}
> +            install -m 0644 ${DTS_BASE_NAME} ${D}/boot/devicetree-${DTB_SYMLINK_NAME}.dtb
> +        done
>       fi
>   }
>
> +do_deploy_append() {
> +    if test -n "${KERNEL_DEVICETREE}"; then
> +        for DTS_FILE in ${KERNEL_DEVICETREE}; do
> +            if [ ! -f ${DTS_FILE} ]; then
> +                echo "Warning: ${DTS_FILE} is not available!"
> +                continue
> +            fi
> +            DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> +            DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> +            DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> +            install -d ${DEPLOYDIR}
> +            install -m 0644 ${B}/${DTS_BASE_NAME} ${DEPLOYDIR}/${DTB_NAME}.dtb
> +            cd ${DEPLOYDIR}
> +            ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
> +            cd -
> +        done
> +    fi
> +}
>




  parent reply	other threads:[~2012-07-16 23:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  3:53 linux-dtb: add multi-dtb build support b19537
2012-06-28 17:12 ` Saul Wold
2012-07-05 18:29   ` McClintock Matthew-B29882
2012-07-05 19:38     ` Scott Garman
2012-07-05 19:59     ` Scott Garman
2012-07-05 20:52       ` McClintock Matthew-B29882
2012-07-05 21:33         ` Scott Garman
2012-07-05 21:37           ` McClintock Matthew-B29882
2012-07-05 22:07             ` Scott Garman
2012-07-20 14:43               ` McClintock Matthew-B29882
2012-07-16 22:48 ` Saul Wold [this message]
2012-07-16 22:50   ` McClintock Matthew-B29882
2012-07-20 14:42     ` McClintock Matthew-B29882
2012-08-20  6:10       ` Luo Zhenhua-B19537

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50049A4F.2040100@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.