From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
Subject: Re: [PATCH 1/8] fsfreeze: Prevent emergency thaw from looping infinitely
Date: Tue, 17 Jul 2012 14:13:53 +0900
Message-ID: <5004F491.5010207@lab.ntt.co.jp>
References: <1342083464.7033.6.camel@nexus.lab.ntt.co.jp> <1342083727.7033.8.camel@nexus.lab.ntt.co.jp> <20120713125924.GD20361@quack.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Dave Chinner <dchinner@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:51259 "EHLO
	tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754365Ab2GQFON (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 17 Jul 2012 01:14:13 -0400
In-Reply-To: <20120713125924.GD20361@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi Jan, Dave,

(2012/07/13 21:59), Jan Kara wrote:

> On Thu 12-07-12 18:02:07, Fernando Luis V=E1zquez Cao wrote:
>> The thawing of a filesystem through sysrq-j loops infinitely as it
>> incorrectly detects a thawed filesytsem as frozen and tries to
>> unfreeze repeatedly. This is a regression caused by
>> 4504230a71566785a05d3e6b53fa1ee071b864eb ("freeze_bdev: grab active
>> reference to frozen superblocks") in that it no longer returned
>> -EINVAL for superblocks that were not frozen.
>>
>> Return -EINVAL when the filesystem is already unfrozen to avoid this
>> problem.
>>
>> Cc: Christoph Hellwig <hch@infradead.org>
>> Cc: Jan Kara <jack@suse.cz>
>> Signed-off-by: Dave Chinner <dchinner@redhat.com>
>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
>    Looks good. You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>

Jan, thank you for the detailed review of the patch set. I really appre=
ciate it.

This week I am pretty busy with other stuff so I may not be able to add=
ress your
comments and Dave's until next Monday.

Regards,
=46ernando

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html