All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bala Shanmugam <bkamatch@qca.qualcomm.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: Add support for AR6004 chipset.
Date: Tue, 17 Jul 2012 09:16:04 +0300	[thread overview]
Message-ID: <50050324.2090001@qca.qualcomm.com> (raw)
In-Reply-To: <1342505284-12315-1-git-send-email-bkamatch@qca.qualcomm.com>

On 07/17/2012 09:08 AM, Bala Shanmugam wrote:
> Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>

Change the title as it's misleading. ath6kl already has ar6004, you are
just adding hw1.3 support.

And please write something in the commit log, like:

"Add support for AR6004 hardware version 1.3 which has id 0x31c8088a."

Otherwise looks good to me.

Kalle

      reply	other threads:[~2012-07-17  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17  6:08 [PATCH] ath6kl: Add support for AR6004 chipset Bala Shanmugam
2012-07-17  6:16 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50050324.2090001@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=bkamatch@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.