All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Monin" <benoit.monin@bootlin.com>
To: Conor Dooley <conor@kernel.org>
Cc: "Andi Shyti" <andi.shyti@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Jan Dabros" <jsd@semihalf.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Dmitry Guzman" <dmitry.guzman@mobileye.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v2 1/5] dt-bindings: i2c: dw: Add Mobileye I2C controllers
Date: Thu, 06 Nov 2025 10:42:40 +0100	[thread overview]
Message-ID: <5005364.OV4Wx5bFTl@benoit.monin> (raw)
In-Reply-To: <20251031-segment-chance-40ba410eb55a@spud>

Hi Conor,

On Friday, 31 October 2025 at 15:58:49 CET, Conor Dooley wrote:
> On Fri, Oct 31, 2025 at 03:35:39PM +0100, Benoît Monin wrote:
> > Add compatible string for the I2C controllers present in Mobileye
> > Eyeq6Lplus SoC. The same controllers are also present in the EyeQ7H.
> 
> Then where is the compatible for the q7h?
> 
I had both entries in version 1 of the patch but Krzysztof told me to
avoid creating duplicated entries. Should I just drop the EyeQ7H
mention in the commit message?

> pw-bot: changes-requested
> 
> > 
> > Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > index d904191bb0c6..bc84631f28d1 100644
> > --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > @@ -36,6 +36,7 @@ properties:
> >          const: baikal,bt1-sys-i2c
> >        - items:
> >            - enum:
> > +              - mobileye,eyeq6lplus-i2c
> >                - mscc,ocelot-i2c
> >                - sophgo,sg2044-i2c
> >                - thead,th1520-i2c
> > 
> 

Best regards,
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com




  reply	other threads:[~2025-11-06  9:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 14:35 [PATCH v2 0/5] i2c: designware: Improve support of multi-messages transfer Benoît Monin
2025-10-31 14:35 ` [PATCH v2 1/5] dt-bindings: i2c: dw: Add Mobileye I2C controllers Benoît Monin
2025-10-31 14:58   ` Conor Dooley
2025-11-06  9:42     ` Benoît Monin [this message]
2025-11-06 10:36       ` Krzysztof Kozlowski
2025-10-31 14:35 ` [PATCH v2 2/5] i2c: designware: Optimize flag reading in i2c_dw_read() Benoît Monin
2025-10-31 14:48   ` Andy Shevchenko
2025-11-06 10:46     ` Benoît Monin
2025-11-06 10:50     ` Krzysztof Kozlowski
2025-11-06 11:08       ` Andy Shevchenko
2025-10-31 14:35 ` [PATCH v2 3/5] i2c: designware: Sort compatible strings in alphabetical order Benoît Monin
2025-10-31 14:52   ` Andy Shevchenko
2025-10-31 14:35 ` [PATCH v2 4/5] i2c: designware: Implement I2C_M_STOP support Benoît Monin
2025-10-31 14:57   ` Andy Shevchenko
2025-11-03 10:39   ` Mika Westerberg
2025-11-06 14:38     ` Benoît Monin
2025-10-31 14:35 ` [PATCH v2 5/5] i2c: designware: Support of controller with IC_EMPTYFIFO_HOLD_MASTER disabled Benoît Monin
2025-11-03 10:43   ` Mika Westerberg
2025-11-03 13:20     ` Andy Shevchenko
2025-11-03 13:30       ` Mika Westerberg
2025-11-06 15:40     ` Benoît Monin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005364.OV4Wx5bFTl@benoit.monin \
    --to=benoit.monin@bootlin.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.guzman@mobileye.com \
    --cc=gregory.clement@bootlin.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.