From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrC7r-0003Sk-F2 for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:04:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrC7q-00070d-Az for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:03:59 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:19146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrC7q-0006zs-4o for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:03:58 -0400 Received: from eusync3.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M7B00854GVK1W00@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 17 Jul 2012 19:04:32 +0100 (BST) Received: from [106.109.9.94] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M7B00D47GUCGP50@eusync3.samsung.com> for qemu-devel@nongnu.org; Tue, 17 Jul 2012 19:03:52 +0100 (BST) Date: Tue, 17 Jul 2012 22:03:48 +0400 From: Igor Mitsyanko In-reply-to: <1342546459-21993-1-git-send-email-i.mitsyanko@samsung.com> Message-id: <5005A904.5000006@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1342546459-21993-1-git-send-email-i.mitsyanko@samsung.com> Subject: Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: e.voevodin@samsung.com, qemu-devel@nongnu.org, agraf@suse.de, kyungmin.park@samsung.com, kraxel@redhat.com, afaerber@suse.de I see now that this bug was already noticed, please ignore this mail On 07/17/2012 09:34 PM, Igor Mitsyanko wrote: > After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure= tests are > executed with -Werror flag. Current ALSA configure test program inv= okes a warning: > > warning: =E2=80=98handle=E2=80=99 is used uninitialized in this fun= ction [-Wuninitialized] > > which results in error with -Werror flag and, consequently, in alsa= test failing. > This means that QEMU won't configure with "--audio-drv-list=3Dalsa"= . > > Initialize "handle" variable to fix compilation warning. > > Signed-off-by: Igor Mitsyanko > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 0a3896e..cf4669f 100755 > --- a/configure > +++ b/configure > @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do > case $drv in > alsa) > audio_drv_probe $drv alsa/asoundlib.h -lasound \ > - "snd_pcm_t **handle; return snd_pcm_close(*handle);" > + "snd_pcm_t *handle =3D 0; return snd_pcm_close(handle);" > libs_softmmu=3D"-lasound $libs_softmmu" > ;; > >