From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] Wrong common field name in GFX Wakeups event
Date: Tue, 17 Jul 2012 15:10:12 -0700 [thread overview]
Message-ID: <5005E2C4.1050204@linux.intel.com> (raw)
In-Reply-To: 4FFD1A0C.90704@samsung.com
[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]
On 07/10/2012 11:15 PM, Igor Zhbanov wrote:
> Hello!
>
> I have found that PowerTOP doesn't displays values in "GFX Wakeups/s"
> column.
> It is because of wrong event field name the handle_trace_point() method
> expects to find in a trace event.
>
> Here is the patch:
> --8<--Cut-here----------------------------------------------------------------
>
> diff -purN powertop/src/process/do_process.cpp
> powertop-new/src/process/do_process.cpp
> --- powertop/src/process/do_process.cpp 2012-07-05
> 13:06:16.080258858 +0400
> +++ powertop-new/src/process/do_process.cpp 2012-07-06
> 13:31:14.382651388 +0400
> @@ -340,7 +340,7 @@ void perf_process_bundle::handle_trace_p
> int flags;
> int pid;
>
> - ret = pevent_get_common_field_val(NULL, event,
> "flags",&rec,&val, 0);
> + ret = pevent_get_common_field_val(NULL, event,
> "common_flags",&rec,&val, 0);
> if (ret< 0)
> return;
> flags = (int)val;
> @@ -625,7 +625,7 @@ void perf_process_bundle::handle_trace_p
> class power_consumer *consumer = NULL;
> int flags;
>
> - ret = pevent_get_common_field_val(NULL, event,
> "flags",&rec,&val, 0);
> + ret = pevent_get_common_field_val(NULL, event,
> "common_flags",&rec,&val, 0);
> if (ret< 0)
> return;
> flags = (int)val;
> --8<--------------------------------------------------------------------------
>
>
> Thank you.
>
>
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
Your patch has been merged.
Thank you,
next reply other threads:[~2012-07-17 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 22:10 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-11 8:33 [Powertop] Wrong common field name in GFX Wakeups event Igor Zhbanov
2012-07-11 6:15 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005E2C4.1050204@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.