From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] net: get rid of SET_ETHTOOL_OPS
Date: Wed, 02 Jul 2014 11:48:51 +0200
Message-ID: <5006516.KlozUPNl4J@xps13>
References: <1404238780-19596-1-git-send-email-fbl@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Flavio Leitner <fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1404238780-19596-1-git-send-email-fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Flavio,

2014-07-01 15:19, Flavio Leitner:
> The SET_ETHTOOL_OPS has been removed from upstream, so it
> breaks the dpdk build with recent kernels.
> 
> Signed-off-by: Flavio Leitner <fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

You are removing SET_ETHTOOL_OPS calls.
In a previous patch, Aaro Koskinen made the choice to redefine the macro
in kcompat files.
I don't know what will be the choice of Intel in the sourceforge base driver.
So I've applied Aaro's patch as there are less modifications of the base 
driver:
	http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411

It would be better to have patches from people working on the base driver.
So upgrades from sourceforge driver to KNI would be smoother.

Thanks
-- 
Thomas