All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>
Subject: HDA_PINCFG_NO_HP_FIXUP question
Date: Wed, 18 Jul 2012 08:27:02 +0200	[thread overview]
Message-ID: <50065736.806@canonical.com> (raw)

Hi,

I'm trying to fix a bug where the docking station is not working. I 
started by adding pins for them (because that was not present), like this:

	[ALC269_FIXUP_LENOVO_DOCK] = {
		.type = ALC_FIXUP_PINS,
		.v.pins = (const struct alc_pincfg[]) {
			{ 0x19, 0x23a11040 }, /* dock mic */
			{ 0x1b, 0x2121103f }, /* dock headphone */
			{ }
		},
	},

However, this caused the real (non-dock) headphone out to "fixed up" to 
a line out, which is wrong. I'm a little unsure about the best way to 
resolve this, I can think of a few different options:

1) Also override the non-dock headphone out to have sequence number 0xf

2) Set parse_flags to HDA_PINCFG_NO_HP_FIXUP in patch_alc269

3) Try to improve the fix up algorithm to not fix up this particular 
case, but since I don't know when and where this was needed in the first 
place, I'm not sure how to do that without throwing the baby out with 
the bath water...?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

             reply	other threads:[~2012-07-18  6:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  6:27 David Henningsson [this message]
2012-07-18  6:44 ` HDA_PINCFG_NO_HP_FIXUP question Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50065736.806@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.