From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: RFC: [PATCH 1/1] toolchain-scripts: Sync the SDK/ADT values to the build system
Date: Wed, 18 Jul 2012 00:52:45 -0700 [thread overview]
Message-ID: <50066B4D.2000002@linux.intel.com> (raw)
In-Reply-To: <a5c0682f85ac03ea09346d504843d362ab153911.1341953258.git.mark.hatle@windriver.com>
On 07/10/2012 01:54 PM, Mark Hatle wrote:
> The build system passes specific TUNE (fundamental) flag values to various
> tools instead of using a shell wrapper or similar. It is important that the
> build system and ADT/SDK match the behaviors exactly, or we are likely to
> have differences in the way build-system and external components are built
> leading to configuration, compilation and/or run-time problems.
>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
> meta/classes/toolchain-scripts.bbclass | 63 +++++++++++++++++++++++---------
> 1 files changed, 45 insertions(+), 18 deletions(-)
>
> diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> index bedcd61..bf37ec9 100644
> --- a/meta/classes/toolchain-scripts.bbclass
> +++ b/meta/classes/toolchain-scripts.bbclass
> @@ -14,9 +14,18 @@ toolchain_create_sdk_env_script () {
> echo 'export PKG_CONFIG_SYSROOT_DIR=${SDKTARGETSYSROOT}' >> $script
> echo 'export PKG_CONFIG_PATH=${SDKTARGETSYSROOT}${libdir}/pkgconfig' >> $script
> echo 'export CONFIG_SITE=${SDKPATH}/site-config-${REAL_MULTIMACH_TARGET_SYS}' >> $script
> - echo 'export CC=${TARGET_PREFIX}gcc' >> $script
> - echo 'export CXX=${TARGET_PREFIX}g++' >> $script
> + echo 'export CC="${TARGET_PREFIX}gcc ${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> + echo 'export CXX="${TARGET_PREFIX}g++ ${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> + echo 'export CPP="${TARGET_PREFIX}gcc -E ${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> + echo 'export AS="${TARGET_PREFIX}as ${TARGET_AS_ARCH}"' >> $script
> + echo 'export LD="${TARGET_PREFIX}ld ${TARGET_LD_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> echo 'export GDB=${TARGET_PREFIX}gdb' >> $script
> + echo 'export STRIP=${TARGET_PREFIX}strip' >> $script
> + echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> + echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> + echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> + echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> + echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=${SDKTARGETSYSROOT}"' >> $script
> if [ "${TARGET_OS}" = "darwin8" ]; then
> @@ -26,10 +35,10 @@ toolchain_create_sdk_env_script () {
> cd ${SDK_OUTPUT}${SDKTARGETSYSROOT}/usr
> ln -s /usr/local local
> fi
> - echo 'export CFLAGS="${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> - echo 'export CXXFLAGS="${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> - echo 'export LDFLAGS="${TARGET_LD_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> - echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=${SDKTARGETSYSROOT}"' >> $script
> + echo 'export CFLAGS="${TARGET_CFLAGS}"' >> $script
> + echo 'export CXXFLAGS="${TARGET_CXXFLAGS}"' >> $script
> + echo 'export LDFLAGS="${TARGET_LDFLAGS}"' >> $script
> + echo 'export CPPFLAGS="${TARGET_CPPFLAGS}"' >> $script
> echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script
> echo 'export OECORE_TARGET_SYSROOT="${SDKTARGETSYSROOT}"' >> $script
> echo 'export OECORE_ACLOCAL_OPTS="-I ${SDKPATHNATIVE}/usr/share/aclocal"' >> $script
> @@ -49,9 +58,18 @@ toolchain_create_tree_env_script () {
>
> echo 'export CONFIG_SITE="${@siteinfo_get_files(d)}"' >> $script
>
> - echo 'export CC=${TARGET_PREFIX}gcc' >> $script
> - echo 'export CXX=${TARGET_PREFIX}g++' >> $script
> + echo 'export CC="${TARGET_PREFIX}gcc ${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> + echo 'export CXX="${TARGET_PREFIX}g++ ${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> + echo 'export CPP="${TARGET_PREFIX}gcc -E ${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> + echo 'export AS="${TARGET_PREFIX}as ${TARGET_AS_ARCH}"' >> $script
> + echo 'export LD="${TARGET_PREFIX}ld ${TARGET_LD_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> echo 'export GDB=${TARGET_PREFIX}gdb' >> $script
> + echo 'export STRIP=${TARGET_PREFIX}strip' >> $script
> + echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> + echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> + echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> + echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> + echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
> if [ "${TARGET_OS}" = "darwin8" ]; then
> @@ -61,10 +79,10 @@ toolchain_create_tree_env_script () {
> cd ${SDK_OUTPUT}${SDKTARGETSYSROOT}/usr
> ln -s /usr/local local
> fi
> - echo 'export CFLAGS="${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> - echo 'export CXXFLAGS="${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> - echo 'export LDFLAGS="${TARGET_LD_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> - echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=${STAGING_DIR_TARGET}"' >> $script
> + echo 'export CFLAGS="${TARGET_CFLAGS}"' >> $script
> + echo 'export CXXFLAGS="${TARGET_CXXFLAGS}"' >> $script
> + echo 'export LDFLAGS="${TARGET_LDFLAGS}"' >> $script
> + echo 'export CPPFLAGS="${TARGET_CPPFLAGS}"' >> $script
> echo 'export OECORE_NATIVE_SYSROOT="${STAGING_DIR_NATIVE}"' >> $script
> echo 'export OECORE_TARGET_SYSROOT="${STAGING_DIR_TARGET}"' >> $script
> echo 'export OECORE_ACLOCAL_OPTS="-I ${STAGING_DIR_NATIVE}/usr/share/aclocal"' >> $script
> @@ -83,9 +101,18 @@ toolchain_create_sdk_env_script_for_installer () {
> echo 'export PKG_CONFIG_SYSROOT_DIR=##SDKTARGETSYSROOT##' >> $script
> echo 'export PKG_CONFIG_PATH=##SDKTARGETSYSROOT##${target_libdir}/pkgconfig' >> $script
> echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script
> - echo 'export CC=${TARGET_PREFIX}gcc' >> $script
> - echo 'export CXX=${TARGET_PREFIX}g++' >> $script
> + echo 'export CC="${TARGET_PREFIX}gcc ${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> + echo 'export CXX="${TARGET_PREFIX}g++ ${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> + echo 'export CPP="${TARGET_PREFIX}gcc -E ${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> + echo 'export AS="${TARGET_PREFIX}as ${TARGET_AS_ARCH}"' >> $script
> + echo 'export LD="${TARGET_PREFIX}ld ${TARGET_LD_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> echo 'export GDB=${TARGET_PREFIX}gdb' >> $script
> + echo 'export STRIP=${TARGET_PREFIX}strip' >> $script
> + echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> + echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> + echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> + echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> + echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=##SDKTARGETSYSROOT##"' >> $script
> if [ "${TARGET_OS}" = "darwin8" ]; then
> @@ -95,10 +122,10 @@ toolchain_create_sdk_env_script_for_installer () {
> cd ${SDK_OUTPUT}${SDKTARGETSYSROOT}/usr
> ln -s /usr/local local
> fi
> - echo 'export CFLAGS="${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> - echo 'export CXXFLAGS="${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> - echo 'export LDFLAGS="${TARGET_LD_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> - echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=##SDKTARGETSYSROOT##"' >> $script
> + echo 'export CFLAGS="${TARGET_CFLAGS}"' >> $script
> + echo 'export CXXFLAGS="${TARGET_CXXFLAGS}"' >> $script
> + echo 'export LDFLAGS="${TARGET_LDFLAGS}"' >> $script
> + echo 'export CPPFLAGS="${TARGET_CPPFLAGS}"' >> $script
> echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script
> echo 'export OECORE_TARGET_SYSROOT="##SDKTARGETSYSROOT##"' >> $script
> echo 'export OECORE_ACLOCAL_OPTS="-I ${SDKPATHNATIVE}/usr/share/aclocal"' >> $script
>
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-07-18 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 20:54 RFC: [PATCH 0/1] Build system/SDK/ADT differ in toolchain config Mark Hatle
2012-07-10 20:54 ` RFC: [PATCH 1/1] toolchain-scripts: Sync the SDK/ADT values to the build system Mark Hatle
2012-07-11 10:48 ` Richard Purdie
2012-07-11 10:48 ` [OE-core] " Richard Purdie
2012-07-18 7:52 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50066B4D.2000002@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.