From: Igor Zhbanov <i.zhbanov at samsung.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Get rid of ncurses' TRUE and FALSE
Date: Wed, 18 Jul 2012 17:21:19 +0400 [thread overview]
Message-ID: <5006B84F.7020104@samsung.com> (raw)
In-Reply-To: 5006B615.1000305@linux.intel.com
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
Arjan van de Ven wrote:
> On 7/18/2012 2:17 AM, Igor Zhbanov wrote:
>> Get rid of TRUE and FALSE ncurses' defines used for boolean variables
>> initialization. This fix also helps build without ncurses support.
> while I appreciate going to C++ true/false, building without ncurses
> isn't really a goal.
> (even on android, building ncurses is easy, and it does make the tool SO
> much more useful)
It is not good that C++ code depends on TRUE/FALSE defines
(defined in ncurses.h) in functions that are not related to ncurses.
P.S. I have merged Intel's and Linaro's repositories and will send patches for
review soon. I don't know why but Linaro wants to build PowerTOP without ncurses.
So I will send a patch that makes ncurses and libpci dependencies conditional.
--
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com
ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation
next reply other threads:[~2012-07-18 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 13:21 Igor Zhbanov [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-23 15:09 [Powertop] [PATCH] Get rid of ncurses' TRUE and FALSE Chris Ferron
2012-07-23 13:23 Arjan van de Ven
2012-07-23 7:48 Igor Zhbanov
2012-07-23 7:31 Magnus Fromreide
2012-07-23 6:32 Igor Zhbanov
2012-07-20 17:32 Chris Ferron
2012-07-20 7:06 Igor Zhbanov
2012-07-19 20:26 Arjan van de Ven
2012-07-19 20:20 Chris Ferron
2012-07-18 22:02 Chris Ferron
2012-07-18 13:11 Arjan van de Ven
2012-07-18 9:17 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5006B84F.7020104@samsung.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.