From: Kevin Wolf <kwolf@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, riegamaths@gmail.com
Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: correct size parsers and help message
Date: Wed, 18 Jul 2012 15:32:38 +0200 [thread overview]
Message-ID: <5006BAF6.6040101@redhat.com> (raw)
In-Reply-To: <1342617786-22107-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Am 18.07.2012 15:23, schrieb Dong Xu Wang:
> qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct
> it in help message.
>
> Also use the same parser in parse_option_size function.
This is not what the patch does. It uses a parser that seems slightly
more compatible with strtosz_suffix() than before, but it still doesn't
use the same one. It really should call strtosz_suffix() instead of
implementing a parser here.
Kevin
next prev parent reply other threads:[~2012-07-18 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 13:23 [Qemu-devel] [PATCH v3] qemu-img: correct size parsers and help message Dong Xu Wang
2012-07-18 13:32 ` Kevin Wolf [this message]
2012-07-18 13:34 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5006BAF6.6040101@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riegamaths@gmail.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.