All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Make libpci dependency optional
Date: Wed, 18 Jul 2012 08:31:15 -0700	[thread overview]
Message-ID: <5006D6C3.6040205@linux.intel.com> (raw)
In-Reply-To: 1342623237-30526-1-git-send-email-i.zhbanov@samsung.com

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

On 7/18/2012 7:53 AM, Igor Zhbanov wrote:
> +#ifndef DISABLE_PCI
>  	if (strcmp(bus, "pci") == 0) {
>  		char filename[4096];
>  		uint16_t vendor = 0, device = 0;
> @@ -77,6 +79,8 @@ runtime_tunable::runtime_tunable(const char *path, const char *bus, const char *
>  
>  
>  	}
> +#endif /* !DISABLE_PCI */

and this chunk is just silly

if you don't have PCI, this code will never trigger in the first place.



             reply	other threads:[~2012-07-18 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 15:31 Arjan van de Ven [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-07-18 15:30 [Powertop] [PATCH] Make libpci dependency optional Arjan van de Ven
2012-07-18 14:53 Igor Zhbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5006D6C3.6040205@linux.intel.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.