Re: [Powertop] [PATCH] Add support to store boardname in /data directory

[Chris Ferron <chris.e.ferron at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On 07/18/2012 07:53 AM, Igor Zhbanov wrote:
> Add support to store boardname in /data directory.
> This patch is based on Linaro's changes.
> ---
>   src/main.cpp |   15 +++++++++++----
>   1 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/src/main.cpp b/src/main.cpp
> index 7a1b976..8a68533 100644
> --- a/src/main.cpp
> +++ b/src/main.cpp
> @@ -240,12 +240,19 @@ static void load_board_params()
>   	string boardname;
>   	char filename[4096];
>   
> -	boardname = read_sysfs_string("/etc/boardname");
> +	if (access("/etc/boardname", R_OK) == 0) {
> +		boardname = read_sysfs_string("/etc/boardname");
>   
> -	if (boardname.length() < 2)
> -		return;
> +		if (boardname.length() < 2)
> +			return;
>   
> -	sprintf(filename, "/var/cache/powertop/saved_parameters.powertop.%s", boardname.c_str());
> +		sprintf(filename,
> +			"/var/cache/powertop/saved_parameters.powertop.%s",
> +			boardname.c_str());
> +	} else if (access("/data", R_OK) == 0)
> +		sprintf(filename,"saved_parameters.powertop");
> +	else
> +		return;
>   
>   	if (access(filename, R_OK))
>   		return;
Thank you for this patch, but 'we' consider boardname now deprecated. As 
such there is a future commit that will remove this code upcoming. As 
such your patch will not be needed.
-Chris