From: Damian Hobson-Garcia <dhobsong@igel.co.jp>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 7/9] fbdev: sh_mobile_lcdc: Support horizontal panning
Date: Thu, 19 Jul 2012 01:40:03 +0000 [thread overview]
Message-ID: <50076573.1020901@igel.co.jp> (raw)
In-Reply-To: <1342658362-19491-8-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On 2012/07/19 9:39, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/video/sh_mobile_lcdcfb.c | 22 ++++++++++++++++------
> 1 files changed, 16 insertions(+), 6 deletions(-)
>
> - if (ovl->format->fourcc = V4L2_PIX_FMT_NV12 ||
> - ovl->format->fourcc = V4L2_PIX_FMT_NV21)
> + switch (ovl->format->fourcc) {
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> + info->fix.xpanstep = 2;
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> info->fix.ypanstep = 2;
> + }
>
> - if (ch->format->fourcc = V4L2_PIX_FMT_NV12 ||
> - ch->format->fourcc = V4L2_PIX_FMT_NV21)
> + switch (ch->format->fourcc) {
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> + info->fix.xpanstep = 2;
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> info->fix.ypanstep = 2;
> + }
>
I think that the panstep settings are backwards. The pansteps should be
NV16: x = 2, y = 1; NV12: x = 2, y = 2.
Cheers,
--
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp
next prev parent reply other threads:[~2012-07-19 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 0:39 [PATCH 7/9] fbdev: sh_mobile_lcdc: Support horizontal panning Laurent Pinchart
2012-07-19 1:40 ` Damian Hobson-Garcia [this message]
2012-07-19 10:20 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50076573.1020901@igel.co.jp \
--to=dhobsong@igel.co.jp \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.