From: Igor Zhbanov <i.zhbanov at samsung.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Make ncurses dependency optional
Date: Thu, 19 Jul 2012 10:26:57 +0400 [thread overview]
Message-ID: <5007A8B1.9090404@samsung.com> (raw)
In-Reply-To: 5006D6FF.7090804@linux.intel.com
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
Arjan van de Ven wrote:
> On 7/18/2012 7:54 AM, Igor Zhbanov wrote:
>> Make ncurses dependency optional. Provide --without-ncurses option
>> to configure.
> I'm sorry but this patch is disgusting;
> PowerTOP uses ncurses. Really.
>
> crapping ifdefs all over the codebase to pretend it does not, we're just
> really not going to do that this way.
I agree that lots of #ifdefs are ugly. But some mobile platforms doesn't
have ncurses. And is is not convenient to run PowerTOP via terminal on it.
Sometimes HTML-report is all that we need. So I try to make possible to build
PowerTOP without ncurses. Linaro's version does the same except that they
just provide -DDISABLE_NCURSES to make without any configure options.
Thank you.
--
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com
ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation
next reply other threads:[~2012-07-19 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 6:26 Igor Zhbanov [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-19 16:02 [Powertop] [PATCH] Make ncurses dependency optional Kok, Auke-jan H
2012-07-19 15:15 Arjan van de Ven
2012-07-18 15:32 Arjan van de Ven
2012-07-18 14:54 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007A8B1.9090404@samsung.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.