From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrkCd-0004rM-4h for qemu-devel@nongnu.org; Thu, 19 Jul 2012 02:27:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrkCb-0004M1-6o for qemu-devel@nongnu.org; Thu, 19 Jul 2012 02:27:11 -0400 Received: from mout.web.de ([212.227.17.11]:58921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrkCa-0004LJ-TQ for qemu-devel@nongnu.org; Thu, 19 Jul 2012 02:27:09 -0400 Message-ID: <5007A8B6.3080604@web.de> Date: Thu, 19 Jul 2012 08:27:02 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <36AF4B62444F4B4FB04EDD1FDAE1CF1D4889875E@G4W3209.americas.hpqcorp.net> <20120612082641.GC12356@redhat.com> <36AF4B62444F4B4FB04EDD1FDAE1CF1D48899822@G4W3209.americas.hpqcorp.net> <20120617083427.GB28089@redhat.com> <4FDDE974.3040001@codemonkey.ws> <4FDEC9A1.4070508@web.de> <36AF4B62444F4B4FB04EDD1FDAE1CF1D488A9E77@G4W3209.americas.hpqcorp.net> In-Reply-To: <36AF4B62444F4B4FB04EDD1FDAE1CF1D488A9E77@G4W3209.americas.hpqcorp.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig027119A986F5007DEE49FDA7" Subject: Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Ma, Stephen B." Cc: "'qemu-devel@nongnu.org'" , Anthony Liguori , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig027119A986F5007DEE49FDA7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-07-18 22:42, Ma, Stephen B. wrote: > Sorry for taking so long to reply. I am new to this. Should this patc= h be committed or just dropped This bug was fixed by 266ca11a0433643a3cc3146a9837d9f2b0bfbe3b in the meantime. Jan >=20 >=20 > -----Original Message----- > From: Jan Kiszka [mailto:jan.kiszka@web.de]=20 > Sent: Sunday, June 17, 2012 11:25 PM > To: Anthony Liguori > Cc: Michael S. Tsirkin; 'qemu-devel@nongnu.org'; Ma, Stephen B. > Subject: Re: [PATCH] Fix for qemu crash on assertion error when adding = PCI passthru device. >=20 > On 2012-06-17 16:28, Anthony Liguori wrote: >> On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote: >>> On Sun, Jun 17, 2012 at 06:26:33AM +0000, Ma, Stephen B. wrote: >>>> >>>> Michael, >>>> >>>> Thanks for the review. I added the unparent to the qdev_free. >>>> >>>> >>>> --- >>>> hw/qdev.c | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/hw/qdev.c b/hw/qdev.c >>>> index d2dc28b..ed1328d 100644 >>>> --- a/hw/qdev.c >>>> +++ b/hw/qdev.c >>>> @@ -264,6 +264,7 @@ void qdev_init_nofail(DeviceState *dev) >>>> /* Unlink device from bus and free the structure. */ >>>> void qdev_free(DeviceState *dev) >>>> { >>>> + object_unparent(OBJECT(dev)); >>>> object_delete(OBJECT(dev)); >>>> } >>>> >>>> -- >>>> 1.7.1 >>> >>> Anthony, any feedback? >> >> Yes, this is wrong. >> >> PCI passthrough isn't in qemu.git so it's not clear to me where this=20 >> is happening. Why would qdev_free be called when adding a PCI=20 >> passthru device? >=20 > The bug is reproducible with any in-tree device (at least PCI) that hap= pens to return !=3D 0 from its init handler. >=20 > Jan >=20 >=20 --------------enig027119A986F5007DEE49FDA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAHqLYACgkQitSsb3rl5xQ8/gCghlYHbpnBAqXIyxXPSewmiMug uYYAn19xyl0DlThZ7M6I2+eJ7QDkkCtK =S2Hd -----END PGP SIGNATURE----- --------------enig027119A986F5007DEE49FDA7--