From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] sanity: display the parsed PATH when complaining about CWD elements
Date: Thu, 19 Jul 2012 00:41:15 -0700 [thread overview]
Message-ID: <5007BA1B.9080806@linux.intel.com> (raw)
In-Reply-To: <1342618950-1081-1-git-send-email-ross.burton@intel.com>
On 07/18/2012 06:42 AM, Ross Burton wrote:
> Many people don't understand the nuances of PATH, so help them by clarifying
> the warning and displaying the parsed PATH element-by-element.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/classes/sanity.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 765958e..5c69d54 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -390,7 +390,8 @@ def check_sanity(sanity_data):
>
> paths = sanity_data.getVar('PATH', True).split(":")
> if "." in paths or "" in paths:
> - messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
> + messages = messages + "PATH contains '.' or '' (empty element), which will break the build, please remove this.\n"
> + messages = messages + "Parsed PATH is " + str(paths) + "\n"
>
> bbpaths = sanity_data.getVar('BBPATH', True).split(":")
> if "." in bbpaths or "" in bbpaths:
>
Looks like this version was merged into OE-Core, please rebase your
updated change and re-sbumit.
Thanks
Sau!
prev parent reply other threads:[~2012-07-19 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 13:42 [PATCH] sanity: display the parsed PATH when complaining about CWD elements Ross Burton
2012-07-18 13:45 ` Martin Jansa
2012-07-18 14:13 ` Burton, Ross
2012-07-19 7:41 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007BA1B.9080806@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.