From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sroi2-0001Ex-IL for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:16:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Srohy-00074d-81 for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:15:54 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:10837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Srohx-00074I-P9 for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:15:50 -0400 Received: from epcpsbgm2.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M7E00A70NA1A050@mailout1.samsung.com> for qemu-devel@nongnu.org; Thu, 19 Jul 2012 20:15:46 +0900 (KST) Received: from [172.21.111.108] ([182.198.1.3]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M7E00AWLNA9ZR80@mmp1.samsung.com> for qemu-devel@nongnu.org; Thu, 19 Jul 2012 20:15:45 +0900 (KST) Date: Thu, 19 Jul 2012 20:16:22 +0900 From: Yeongkyoon Lee In-reply-to: <27581642.449511342490814936.JavaMail.weblogic@epml11> Message-id: <5007EC86.8000707@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=EUC-KR Content-transfer-encoding: QUOTED-PRINTABLE References: <27581642.449511342490814936.JavaMail.weblogic@epml11> Subject: Re: [Qemu-devel] [RFC][PATCH v3 1/3] configure: Add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: yeongkyoon.lee@samsung.com Cc: Blue Swirl , "laurent.desnogues@gmail.com" , "qemu-devel@nongnu.org" , "peter.maydell@linaro.org" Ping? On 2012=B3=E2 07=BF=F9 17=C0=CF 11:06, YeongKyoon Lee wrote: > The reason why softmmu condition in configure is that softmmu is th= ought to be a logical prerequisite of ldst optimization. > Current patch causes compilation error if removed the condition abo= ve. > To avoid compilation error, it needs more macros in other sources, = such as, tcg.c and/or tcg-target.c, because those files are used both= by softmmu and by non-softmmu targets. > > For example, tcg_out_qemu_ldst_slow_path() call site in tcg.c is wr= apped only by CONFIG_QEMU_LDST_OPTIMIZATION, while it calls ldst spec= ific function wrapped by CONFIG_SOFTMMU in tcg/i386/tcg-target.c. > I'm not sure which one is better, CONFIG_SOFTMMU pre-condition in c= onfigure or more those macros in tcg sources. > > How do you think about it? > > ------- Original Message ------- > Sender : Blue Swirl > Date : 2012-07-14 22:13 (GMT+09:00) > Title : Re: [Qemu-devel] [RFC][PATCH v3 1/3] configure: Add CONFIG_= QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization > > On Sat, Jul 14, 2012 at 10:23 AM, Yeongkyoon Lee > wrote: >> Enable CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimizati= on only when >> a target uses softmmu and a host is i386 or x86_64. >> --- >> configure | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index 500fe24..5b39c80 100755 >> --- a/configure >> +++ b/configure >> @@ -3700,6 +3700,14 @@ case "$target_arch2" in >> ;; >> esac >> >> +case "$cpu" in >> + i386|x86_64) >> + if [ "$target_softmmu" =3D "yes" ] ; then > I suppose this check is not needed, user emulators will not use the > memory access helpers or TLB. > >> + echo "CONFIG_QEMU_LDST_OPTIMIZATION=3Dy" >> $config_target_= mak >> + fi >> + ;; >> +esac >> + >> echo "TARGET_SHORT_ALIGNMENT=3D$target_short_alignment" >> $confi= g_target_mak >> echo "TARGET_INT_ALIGNMENT=3D$target_int_alignment" >> $config_ta= rget_mak >> echo "TARGET_LONG_ALIGNMENT=3D$target_long_alignment" >> $config_= target_mak >> -- >> 1.7.4.1 >>