From: Harsh Bora <harsh@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, strings.
Date: Thu, 19 Jul 2012 17:24:21 +0530 [thread overview]
Message-ID: <5007F56D.90003@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJSP0QWjUUfvxWokvSgmFj9qDO-JS8DXi+10P0PjMj4-V++KKQ@mail.gmail.com>
On 07/19/2012 05:22 PM, Stefan Hajnoczi wrote:
> On Thu, Jul 19, 2012 at 12:07 PM, Harsh Prateek Bora
> <harsh@linux.vnet.ibm.com> wrote:
>> Existing simpletrace backend allows to trace at max 6 args and does not
>> support strings. This newer tracelog format gets rid of fixed size records
>> and therefore allows to trace variable number of args including strings.
>>
>> Sample trace:
>> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
>> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
>> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff
>> uname=nobody aname=
>> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80
>> version=0x4f2a4dd0 path=0x220ea6
>>
>> v9:
>> - Renamed TraceRecordHeader to TraceLogHeader as appropriate
>> - Some more code cleanups
>
> We discussed this on IRC. v8 is already in my tracing tree and I have
> sent a pull request.
>
> These code cleanups are nice but can be taken in a follow-up patch.
>
Sure, will do.
Thanks once again,
Harsh
> Stefan
>
prev parent reply other threads:[~2012-07-19 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 11:07 [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, strings Harsh Prateek Bora
2012-07-19 11:07 ` [Qemu-devel] [PATCH v9 1/3] monitor: remove unused do_info_trace Harsh Prateek Bora
2012-07-19 11:07 ` [Qemu-devel] [PATCH v9 2/3] Simpletrace v2: Support multiple arguments, strings Harsh Prateek Bora
2012-07-19 11:07 ` [Qemu-devel] [PATCH v9 3/3] Update simpletrace.py for new log format Harsh Prateek Bora
2012-07-19 11:52 ` [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, strings Stefan Hajnoczi
2012-07-19 11:54 ` Harsh Bora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007F56D.90003@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.