From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation Date: Thu, 19 Jul 2012 17:41:03 +0100 Message-ID: <5008389F.4060401@citrix.com> References: <1342172696-88347-1-git-send-email-roger.pau@citrix.com> <1342172696-88347-17-git-send-email-roger.pau@citrix.com> <20488.14185.962905.269760@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20488.14185.962905.269760@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation"): >> Split libxl_device_vkb_add into libxl__device_vkb_add (to be used >> inside already running ao's), and make libxl_device_vkb_add a stub to >> call libxl__device_vkb_add. > ... >> - dcs->aodevs.size = d_config->num_disks; >> + if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM) { >> + assert(!d_config->vkbs && !d_config->num_vkbs); > > This is rather unfriendly - doesn't it amount to aborting on an > invalid domain configuration. And I'm not sure I understand the > logic, which is new in your patch. This was part of the previous code, but this was done inside of a switch instead of an if. Since it's not possible to specify vkb devices in the config file (at least xl.cfg(5) doesn't mention anything about vkbs), I'm quite sure d_config->vkbs == NULL and d_config->num_vkbs == 0 always or something has gone extremely wrong, just added the abort to be sure.