From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 0/4] rbd: use snapc->seq the way server does
Date: Thu, 19 Jul 2012 12:09:57 -0500 [thread overview]
Message-ID: <50083F65.5030104@inktank.com> (raw)
This series of patches changes the way the snap context "seq" field
is used. Currently it is used in a way that isn't really useful, and
as such is a bit confusing. This behavior seems to be a hold over
from a time when there was no snap_id field maintained for an rbd_dev.
Summary:
[PATCH 1/4] rbd: don't use snapc->seq that way
Removes special handling in __rbd_refresh_header() that ensured
the seq field was updated to point to the head if it had been
at the start of the function.
[PATCH 2/4] rbd: preserve snapc->seq in rbd_header_set_snap()
Changes rbd_header_set_snap() so it doesn't set the seq field
to the snapshot id (for a snapshot mapping) or the highest
snapshot id (for the base image).
[PATCH 3/4] rbd: set snapc->seq only when refreshing header
Assigns snapc->seq whenever an updated rbd image header is
received rather than when a new snapshot id has been
assigned.
[PATCH 4/4] rbd: kill rbd_image_header->snap_seq
Gets rid of the rbd_image_header->snap_seq field, which
previously kept the same information now maintained in
the snapc->seq field.
-Alex
next reply other threads:[~2012-07-19 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 17:09 Alex Elder [this message]
2012-07-19 17:11 ` [PATCH 1/4] rbd: don't use snapc->seq that way Alex Elder
2012-07-19 21:02 ` Josh Durgin
2012-07-19 21:10 ` Alex Elder
2012-07-19 17:11 ` [PATCH 2/4] rbd: preserve snapc->seq in rbd_header_set_snap() Alex Elder
2012-07-19 17:11 ` [PATCH 3/4] rbd: set snapc->seq only when refreshing header Alex Elder
2012-07-19 17:11 ` [PATCH 4/4] rbd: kill rbd_image_header->snap_seq Alex Elder
2012-07-19 22:12 ` [PATCH 0/4] rbd: use snapc->seq the way server does Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50083F65.5030104@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.